From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 4/4] x86/EFI: adjust EFI_MEMORY_WP handling for spec version 2.5 Date: Tue, 9 Jun 2015 11:35:23 -0400 Message-ID: <20150609153522.GF16488@x230> References: <55770B190200007800082A2C@mail.emea.novell.com> <55770C2D0200007800082A4B@mail.emea.novell.com> <20150609140856.GG15200@x230> <557722520200007800082C21@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z2LYp-0002ZG-ES for xen-devel@lists.xenproject.org; Tue, 09 Jun 2015 15:35:31 +0000 Content-Disposition: inline In-Reply-To: <557722520200007800082C21@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On Tue, Jun 09, 2015 at 04:28:50PM +0100, Jan Beulich wrote: > >>> On 09.06.15 at 16:08, wrote: > >> @@ -1220,6 +1224,9 @@ void __init efi_init_memory(void) > >> #define EFI_MEMORY_RP 0x0000000000002000 > >> #define EFI_MEMORY_XP 0x0000000000004000 > >> +#define EFI_MEMORY_RO 0x0000000000020000 > >> + > >> +#define EFI_MEMORY_NV 0x0000000000008000 > >> +#define EFI_MEMORY_MORE_RELIABLE 0x0000000000010000 > > > > Those two are new (NV, MORE_RELIABLE), should they be part > > of a different patch? Or if they are part of the new spec > > just mention in the commit that you are adding it in for > > future use? > > Added > > "Along with EFI_MEMORY_RO also add the two other new EFI_MEMORY_* > definitions, even if we don't need them right away." Reviewed-by: Konrad Rzeszutek Wilk > > Jan >