From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ASoC: wm_adsp: Add code_probe and codec_remove stubs
Date: Tue, 9 Jun 2015 17:13:56 +0100 [thread overview]
Message-ID: <20150609161356.GB27675@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20150609160043.GD14071@sirena.org.uk>
On Tue, Jun 09, 2015 at 05:00:43PM +0100, Mark Brown wrote:
> On Tue, Jun 09, 2015 at 04:16:56PM +0100, Richard Fitzgerald wrote:
>
> > + ret = wm_adsp2_codec_probe(&priv->core.adsp[0], codec);
> > + if (ret)
> > + return ret;
> > +
>
> I'm still not a big fan of the double registration that's being done -
> if nothing else the fact that it's not also factoring out the creation
> of the DSP controls seems wrong.
I don't see the point of trying to fight against the design of ASoC with
the second probe. ASoC gives us what we need at the codec_probe stage
so why try to invent something different?
next prev parent reply other threads:[~2015-06-09 16:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 15:16 [PATCH v2 1/2] ASoC: wm_adsp: Add code_probe and codec_remove stubs Richard Fitzgerald
2015-06-09 15:16 ` [PATCH v2 2/2] ASoC: wm_adsp: Add basic debugfs entries Richard Fitzgerald
2015-06-09 15:16 ` Richard Fitzgerald
2015-06-09 16:00 ` [PATCH v2 1/2] ASoC: wm_adsp: Add code_probe and codec_remove stubs Mark Brown
2015-06-09 16:00 ` Mark Brown
2015-06-09 16:13 ` Richard Fitzgerald [this message]
2015-06-09 16:20 ` Mark Brown
2015-06-09 16:43 ` Richard Fitzgerald
2015-06-09 16:43 ` Richard Fitzgerald
2015-06-09 16:55 ` Mark Brown
2015-06-09 16:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150609161356.GB27675@opensource.wolfsonmicro.com \
--to=rf@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.