From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp04.au.ibm.com ([202.81.31.146]:56120 "EHLO e23smtp04.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932406AbbFJGW1 (ORCPT ); Wed, 10 Jun 2015 02:22:27 -0400 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 10 Jun 2015 16:22:25 +1000 Date: Wed, 10 Jun 2015 16:20:08 +1000 From: Gavin Shan To: Alexey Kardashevskiy Cc: Gavin Shan , linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, benh@kernel.crashing.org, bhelgaas@google.com, panto@antoniou-consulting.com, robherring2@gmail.com, grant.likely@linaro.org, Daniel Axtens Subject: Re: [PATCH v5 12/42] powerpc/pci: Cleanup on pci_controller_ops Message-ID: <20150610062008.GA9875@gwshan> Reply-To: Gavin Shan References: <1433400131-18429-1-git-send-email-gwshan@linux.vnet.ibm.com> <1433400131-18429-13-git-send-email-gwshan@linux.vnet.ibm.com> <5577C08D.1050900@ozlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <5577C08D.1050900@ozlabs.ru> Sender: linux-pci-owner@vger.kernel.org List-ID: On Wed, Jun 10, 2015 at 02:43:57PM +1000, Alexey Kardashevskiy wrote: >On 06/04/2015 04:41 PM, Gavin Shan wrote: >>Each PHB maintains one instance of "struct pci_controller_ops", >>which includes various callbacks called by PCI subsystem. In the >>definition of this struct, some callbacks have explicit names for >>its arguments, but the left don't have. >> >>The patch removes all explicit names of the arguments to the >>callbacks in "struct pci_controller_ops" to keep the code look >>consistent. > >imho it is a bad idea. Self-documeted code gets less self-documented - how do >I know what "unsigned long" parameters are for without grepping? > Ok. I'll change the function definations to always have explicit argument names. >> >>Cc: Daniel Axtens >>Signed-off-by: Gavin Shan >>--- >>v5: >> * Newly introduced >>--- >> arch/powerpc/include/asm/pci-bridge.h | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >>diff --git a/arch/powerpc/include/asm/pci-bridge.h b/arch/powerpc/include/asm/pci-bridge.h >>index 744884b..1252cd5 100644 >>--- a/arch/powerpc/include/asm/pci-bridge.h >>+++ b/arch/powerpc/include/asm/pci-bridge.h >>@@ -18,8 +18,8 @@ struct device_node; >> * PCI controller operations >> */ >> struct pci_controller_ops { >>- void (*dma_dev_setup)(struct pci_dev *dev); >>- void (*dma_bus_setup)(struct pci_bus *bus); >>+ void (*dma_dev_setup)(struct pci_dev *); >>+ void (*dma_bus_setup)(struct pci_bus *); >> >> int (*probe_mode)(struct pci_bus *); >> >>@@ -28,8 +28,8 @@ struct pci_controller_ops { >> bool (*enable_device_hook)(struct pci_dev *); >> >> /* Called during PCI resource reassignment */ >>- resource_size_t (*window_alignment)(struct pci_bus *, unsigned long type); >>- void (*reset_secondary_bus)(struct pci_dev *dev); >>+ resource_size_t (*window_alignment)(struct pci_bus *, unsigned long); >>+ void (*reset_secondary_bus)(struct pci_dev *); >> }; >> >> /* >> Thanks, Gavin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gavin Shan Subject: Re: [PATCH v5 12/42] powerpc/pci: Cleanup on pci_controller_ops Date: Wed, 10 Jun 2015 16:20:08 +1000 Message-ID: <20150610062008.GA9875@gwshan> References: <1433400131-18429-1-git-send-email-gwshan@linux.vnet.ibm.com> <1433400131-18429-13-git-send-email-gwshan@linux.vnet.ibm.com> <5577C08D.1050900@ozlabs.ru> Reply-To: Gavin Shan Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <5577C08D.1050900@ozlabs.ru> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Alexey Kardashevskiy Cc: devicetree@vger.kernel.org, linux-pci@vger.kernel.org, panto@antoniou-consulting.com, Gavin Shan , grant.likely@linaro.org, robherring2@gmail.com, bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org, Daniel Axtens List-Id: devicetree@vger.kernel.org T24gV2VkLCBKdW4gMTAsIDIwMTUgYXQgMDI6NDM6NTdQTSArMTAwMCwgQWxleGV5IEthcmRhc2hl dnNraXkgd3JvdGU6Cj5PbiAwNi8wNC8yMDE1IDA0OjQxIFBNLCBHYXZpbiBTaGFuIHdyb3RlOgo+ PkVhY2ggUEhCIG1haW50YWlucyBvbmUgaW5zdGFuY2Ugb2YgInN0cnVjdCBwY2lfY29udHJvbGxl cl9vcHMiLAo+PndoaWNoIGluY2x1ZGVzIHZhcmlvdXMgY2FsbGJhY2tzIGNhbGxlZCBieSBQQ0kg c3Vic3lzdGVtLiBJbiB0aGUKPj5kZWZpbml0aW9uIG9mIHRoaXMgc3RydWN0LCBzb21lIGNhbGxi YWNrcyBoYXZlIGV4cGxpY2l0IG5hbWVzIGZvcgo+Pml0cyBhcmd1bWVudHMsIGJ1dCB0aGUgbGVm dCBkb24ndCBoYXZlLgo+Pgo+PlRoZSBwYXRjaCByZW1vdmVzIGFsbCBleHBsaWNpdCBuYW1lcyBv ZiB0aGUgYXJndW1lbnRzIHRvIHRoZQo+PmNhbGxiYWNrcyBpbiAic3RydWN0IHBjaV9jb250cm9s bGVyX29wcyIgdG8ga2VlcCB0aGUgY29kZSBsb29rCj4+Y29uc2lzdGVudC4KPgo+aW1obyBpdCBp cyBhIGJhZCBpZGVhLiBTZWxmLWRvY3VtZXRlZCBjb2RlIGdldHMgbGVzcyBzZWxmLWRvY3VtZW50 ZWQgLSBob3cgZG8KPkkga25vdyB3aGF0ICJ1bnNpZ25lZCBsb25nIiBwYXJhbWV0ZXJzIGFyZSBm b3Igd2l0aG91dCBncmVwcGluZz8KPgoKT2suIEknbGwgY2hhbmdlIHRoZSBmdW5jdGlvbiBkZWZp bmF0aW9ucyB0byBhbHdheXMgaGF2ZSBleHBsaWNpdAphcmd1bWVudCBuYW1lcy4KCj4+Cj4+Q2M6 IERhbmllbCBBeHRlbnMgPGRqYUBheHRlbnMubmV0Pgo+PlNpZ25lZC1vZmYtYnk6IEdhdmluIFNo YW4gPGd3c2hhbkBsaW51eC52bmV0LmlibS5jb20+Cj4+LS0tCj4+djU6Cj4+ICAgKiBOZXdseSBp bnRyb2R1Y2VkCj4+LS0tCj4+ICBhcmNoL3Bvd2VycGMvaW5jbHVkZS9hc20vcGNpLWJyaWRnZS5o IHwgOCArKysrLS0tLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNCBkZWxl dGlvbnMoLSkKPj4KPj5kaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNtL3BjaS1i cmlkZ2UuaCBiL2FyY2gvcG93ZXJwYy9pbmNsdWRlL2FzbS9wY2ktYnJpZGdlLmgKPj5pbmRleCA3 NDQ4ODRiLi4xMjUyY2Q1IDEwMDY0NAo+Pi0tLSBhL2FyY2gvcG93ZXJwYy9pbmNsdWRlL2FzbS9w Y2ktYnJpZGdlLmgKPj4rKysgYi9hcmNoL3Bvd2VycGMvaW5jbHVkZS9hc20vcGNpLWJyaWRnZS5o Cj4+QEAgLTE4LDggKzE4LDggQEAgc3RydWN0IGRldmljZV9ub2RlOwo+PiAgICogUENJIGNvbnRy b2xsZXIgb3BlcmF0aW9ucwo+PiAgICovCj4+ICBzdHJ1Y3QgcGNpX2NvbnRyb2xsZXJfb3BzIHsK Pj4tCXZvaWQJCSgqZG1hX2Rldl9zZXR1cCkoc3RydWN0IHBjaV9kZXYgKmRldik7Cj4+LQl2b2lk CQkoKmRtYV9idXNfc2V0dXApKHN0cnVjdCBwY2lfYnVzICpidXMpOwo+PisJdm9pZAkJKCpkbWFf ZGV2X3NldHVwKShzdHJ1Y3QgcGNpX2RldiAqKTsKPj4rCXZvaWQJCSgqZG1hX2J1c19zZXR1cCko c3RydWN0IHBjaV9idXMgKik7Cj4+Cj4+ICAJaW50CQkoKnByb2JlX21vZGUpKHN0cnVjdCBwY2lf YnVzICopOwo+Pgo+PkBAIC0yOCw4ICsyOCw4IEBAIHN0cnVjdCBwY2lfY29udHJvbGxlcl9vcHMg ewo+PiAgCWJvb2wJCSgqZW5hYmxlX2RldmljZV9ob29rKShzdHJ1Y3QgcGNpX2RldiAqKTsKPj4K Pj4gIAkvKiBDYWxsZWQgZHVyaW5nIFBDSSByZXNvdXJjZSByZWFzc2lnbm1lbnQgKi8KPj4tCXJl c291cmNlX3NpemVfdCAoKndpbmRvd19hbGlnbm1lbnQpKHN0cnVjdCBwY2lfYnVzICosIHVuc2ln bmVkIGxvbmcgdHlwZSk7Cj4+LQl2b2lkCQkoKnJlc2V0X3NlY29uZGFyeV9idXMpKHN0cnVjdCBw Y2lfZGV2ICpkZXYpOwo+PisJcmVzb3VyY2Vfc2l6ZV90ICgqd2luZG93X2FsaWdubWVudCkoc3Ry dWN0IHBjaV9idXMgKiwgdW5zaWduZWQgbG9uZyk7Cj4+Kwl2b2lkCQkoKnJlc2V0X3NlY29uZGFy eV9idXMpKHN0cnVjdCBwY2lfZGV2ICopOwo+PiAgfTsKPj4KPj4gIC8qCj4+CgpUaGFua3MsCkdh dmluCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eHBwYy1kZXYgbWFpbGluZyBsaXN0CkxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnCmh0dHBz Oi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9saW51eHBwYy1kZXY=