From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: green@linuxhacker.ru
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] staging/lustre/llite: remove LL_IOC_REMOVE_ENTRY handler
Date: Wed, 10 Jun 2015 12:38:05 +0530 [thread overview]
Message-ID: <20150610070805.GC7035@sudip-PC> (raw)
In-Reply-To: <1433911283-24902-2-git-send-email-green@linuxhacker.ru>
On Wed, Jun 10, 2015 at 12:41:22AM -0400, green@linuxhacker.ru wrote:
> From: Oleg Drokin <green@linuxhacker.ru>
>
> It uses getname in unsafe manner and since it's to deal with corrupted
> or inconsistent filesystem, we are probably better to deal with
> it from lfsck anyway.
I am not sure but will it not break the userspace? There may be some
application who is using this ioctl.
And I think you missed removing the #define LL_IOC_REMOVE_ENTRY from
lustre_user.h which will not be used anymore.
regards
sudip
next prev parent reply other threads:[~2015-06-10 7:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 4:41 [PATCH 0/2] Fixup lusre ll_getname green
2015-06-10 4:41 ` [PATCH 1/2] staging/lustre/llite: remove LL_IOC_REMOVE_ENTRY handler green
2015-06-10 7:08 ` Sudip Mukherjee [this message]
2015-06-10 7:19 ` Oleg Drokin
2015-06-10 4:41 ` [PATCH 2/2] staging/lustre/llite: fix ll_getname user buffer copy green
2015-06-10 7:52 ` Dan Carpenter
2015-06-10 7:59 ` Oleg Drokin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610070805.GC7035@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=green@linuxhacker.ru \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.