From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Andy Furniss <adf.lists@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: dvbv5-tzap with pctv 290e/292e needs EAGAIN for pat/pmt to work when recording.
Date: Wed, 10 Jun 2015 09:52:15 -0300 [thread overview]
Message-ID: <20150610095215.79e5e77e@recife.lan> (raw)
In-Reply-To: <556E2D5B.5080201@gmail.com>
Em Tue, 02 Jun 2015 23:25:31 +0100
Andy Furniss <adf.lists@gmail.com> escreveu:
> Running kernel 3.18.14 with git master v4l-utils and a pctv290e + a 292e.
>
> If I try to record with dvbv5-zap and include the "p" option to get
> pat/pmt I get -
>
> read_sections: read error: Resource temporarily unavailable
> couldn't find pmt-pid for sid 10bf
>
> Doing this this fixes it for me (obviously not meant to be a a proper
> patch).
You forgot to send your Signed-off-by on this patch ;)
Anyway, there are other places where EAGAIN may happen. So, the best
is to fix it globally.
Just applied a fix for it:
http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=c7c9af17163f282a147ea76f1a3c0e9a0a86e7fa
It will retry up to 10 times. This should very likely be enough if the
driver doesn't have any bug.
Please let me know if this fixes the issue.
Regards,
Mauro
>
> diff --git a/lib/libdvbv5/dvb-demux.c b/lib/libdvbv5/dvb-demux.c
> index 30d4eda..b520948 100644
> --- a/lib/libdvbv5/dvb-demux.c
> +++ b/lib/libdvbv5/dvb-demux.c
> @@ -151,8 +151,10 @@ int dvb_get_pmt_pid(int patfd, int sid)
> if (((count = read(patfd, buf, sizeof(buft))) < 0) &&
> errno == EOVERFLOW)
> count = read(patfd, buf, sizeof(buft));
> if (count < 0) {
> - perror("read_sections: read error");
> - return -1;
> + if (errno == EAGAIN) /*ADF*/
> + continue;
> + perror("read_sections: read error");
> + return -1;
> }
>
> section_length = ((buf[1] & 0x0f) << 8) | buf[2];
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-06-10 12:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 22:25 dvbv5-tzap with pctv 290e/292e needs EAGAIN for pat/pmt to work when recording Andy Furniss
2015-06-10 12:52 ` Mauro Carvalho Chehab [this message]
2015-06-10 17:27 ` Andy Furniss
2015-06-10 18:50 ` Mauro Carvalho Chehab
2015-06-10 20:17 ` Mauro Carvalho Chehab
2015-06-10 22:16 ` Andy Furniss
2015-06-10 21:35 ` Andy Furniss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610095215.79e5e77e@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=adf.lists@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.