From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH V4 2/4] KVM: x86/vPMU: Create vPMU interface for VMX and SVM Date: Wed, 10 Jun 2015 12:12:12 +0200 Message-ID: <20150610101212.GB20384@8bytes.org> References: <1433481616-24884-1-git-send-email-wei@redhat.com> <1433481616-24884-3-git-send-email-wei@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, pbonzini@redhat.com, gleb@kernel.org, rkrcmar@redhat.com To: Wei Huang Return-path: Received: from 8bytes.org ([81.169.241.247]:57646 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754199AbbFJKMO (ORCPT ); Wed, 10 Jun 2015 06:12:14 -0400 Content-Disposition: inline In-Reply-To: <1433481616-24884-3-git-send-email-wei@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Jun 05, 2015 at 01:20:14AM -0400, Wei Huang wrote: > + > + struct kvm_pmu_ops *(*get_pmu_ops)(void); Can't you just set kvm_pmu_ops in svm.c and vmx.c and save this call-back? Besides that the patch looks good. Joerg