Re: [PATCH V4 0/4] Consolidated KVM vPMU support for x86

[Joerg Roedel <joro@8bytes.org>]

On Fri, Jun 05, 2015 at 01:20:12AM -0400, Wei Huang wrote:
> Wei Huang (4):
>   KVM: x86/vPMU: Define kvm_pmu_ops to support vPMU function dispatch
>   KVM: x86/vPMU: Create vPMU interface for VMX and SVM
>   KVM: x86/vPMU: Implement AMD vPMU code for KVM
>   KVM: x86/vPMU: Enable PMU handling for AMD PERFCTRn and EVNTSELn MSRs
> 
>  arch/x86/include/asm/kvm_host.h |  50 ++--
>  arch/x86/kvm/Makefile           |   4 +-
>  arch/x86/kvm/cpuid.c            |   3 +-
>  arch/x86/kvm/pmu.c              | 557 +++++++++++-----------------------------
>  arch/x86/kvm/pmu.h              |  99 +++++++
>  arch/x86/kvm/pmu_amd.c          | 207 +++++++++++++++
>  arch/x86/kvm/pmu_intel.c        | 360 ++++++++++++++++++++++++++
>  arch/x86/kvm/svm.c              |   8 +
>  arch/x86/kvm/vmx.c              |   8 +
>  arch/x86/kvm/x86.c              |  76 ++----
>  10 files changed, 896 insertions(+), 476 deletions(-)
>  create mode 100644 arch/x86/kvm/pmu.h
>  create mode 100644 arch/x86/kvm/pmu_amd.c
>  create mode 100644 arch/x86/kvm/pmu_intel.c

Okay, I reviewed and tested the series. It looks good to me, except for
the one comment I had on patch 2.

So feel free to add

	Reviewed-by: Joerg Roedel <jroedel@suse.de>
	Tested-by: Joerg Roedel <jroedel@suse.de>

to patches 1, 3, and 4 in the next interation.


	Joerg