From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-fbdev@vger.kernel.org
Subject: re: video, sm501: add OF binding to support SM501
Date: Wed, 10 Jun 2015 15:51:32 +0000 [thread overview]
Message-ID: <20150610155132.GK10549@mwanda> (raw)
Hello Heiko Schocher,
The patch 4295f9bf74a8: "video, sm501: add OF binding to support
SM501" from Jan 26, 2011, leads to the following static checker
warning:
drivers/video/fbdev/sm501fb.c:1958 sm501fb_probe()
warn: strcpy() 'cp' of unknown size might be too large for 'fb_mode'
drivers/video/fbdev/sm501fb.c
46 static char *fb_mode = "640x480-16@60";
[ snip ]
1953 info->pdata = &sm501fb_def_pdata;
1954 if (np) {
1955 /* Get EDID */
1956 cp = of_get_property(np, "mode", &len);
1957 if (cp)
1958 strcpy(fb_mode, cp);
I don't know anything about this hardware but there might be a mode
longer than "640x480-16@60"?
1959 prop = of_get_property(np, "edid", &len);
1960 if (prop && len = EDID_LENGTH) {
regards,
dan carpenter
next reply other threads:[~2015-06-10 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 15:51 Dan Carpenter [this message]
2015-06-11 9:24 ` video, sm501: add OF binding to support SM501 Heiko Schocher
2015-06-11 9:32 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610155132.GK10549@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.