From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch] ASoC: fsl: add an error check Date: Wed, 10 Jun 2015 22:17:32 +0300 Message-ID: <20150610191732.GC11734@mwanda> References: <20150610153723.GB10549@mwanda> <20150610165544.GA8552@Asurada> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by alsa0.perex.cz (Postfix) with ESMTP id 19E9A265E00 for ; Wed, 10 Jun 2015 21:17:49 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20150610165544.GA8552@Asurada> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Nicolin Chen Cc: alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , Takashi Iwai , kernel-janitors@vger.kernel.org, Liam Girdwood , Mark Brown , linuxppc-dev@lists.ozlabs.org List-Id: alsa-devel@alsa-project.org > Could you please use an subject like: > ASoC: imx-wm8962: Add a missing error check > (Since it only applies to this file) > I have been meaning to say something about this. This is sort of a recurrent problem for me because I'm often the first person to touch a driver after it's added. I just copied your patch prefix from 8de2ae2a7f1f ('ASoC: fsl: add imx-wm8962 machine driver'). Really you should also have used "ASoC: imx-wm8962:" as well. This is the third new driver today where I have faced this situation. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 10 Jun 2015 19:17:32 +0000 Subject: Re: [patch] ASoC: fsl: add an error check Message-Id: <20150610191732.GC11734@mwanda> List-Id: References: <20150610153723.GB10549@mwanda> <20150610165544.GA8552@Asurada> In-Reply-To: <20150610165544.GA8552@Asurada> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Nicolin Chen Cc: alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , Takashi Iwai , kernel-janitors@vger.kernel.org, Liam Girdwood , Mark Brown , linuxppc-dev@lists.ozlabs.org > Could you please use an subject like: > ASoC: imx-wm8962: Add a missing error check > (Since it only applies to this file) > I have been meaning to say something about this. This is sort of a recurrent problem for me because I'm often the first person to touch a driver after it's added. I just copied your patch prefix from 8de2ae2a7f1f ('ASoC: fsl: add imx-wm8962 machine driver'). Really you should also have used "ASoC: imx-wm8962:" as well. This is the third new driver today where I have faced this situation. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id A13CE1A0E6B for ; Thu, 11 Jun 2015 05:18:01 +1000 (AEST) Date: Wed, 10 Jun 2015 22:17:32 +0300 From: Dan Carpenter To: Nicolin Chen Cc: Timur Tabi , Xiubo Li , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] ASoC: fsl: add an error check Message-ID: <20150610191732.GC11734@mwanda> References: <20150610153723.GB10549@mwanda> <20150610165544.GA8552@Asurada> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20150610165544.GA8552@Asurada> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > Could you please use an subject like: > ASoC: imx-wm8962: Add a missing error check > (Since it only applies to this file) > I have been meaning to say something about this. This is sort of a recurrent problem for me because I'm often the first person to touch a driver after it's added. I just copied your patch prefix from 8de2ae2a7f1f ('ASoC: fsl: add imx-wm8962 machine driver'). Really you should also have used "ASoC: imx-wm8962:" as well. This is the third new driver today where I have faced this situation. regards, dan carpenter