Re: [PATCH V4 2/4] KVM: x86/vPMU: Create vPMU interface for VMX and SVM

[Joerg Roedel <joro@8bytes.org>]

On Wed, Jun 10, 2015 at 01:47:42PM -0500, Wei Huang wrote:
> On 06/10/2015 01:05 PM, Joerg Roedel wrote:
> > So how about putting the pmu-ops directly into the kvm_x86_ops as a
> > (const) member, 
> I like this idea better. Here is the (expanded) design:
> 
> 1) add const "struct kvm_pmu_ops *pmu_ops" to kvm_x86_ops;
> 2) In VMX, "vmx_x86_ops.pmu_ops = &intel_pmu_ops";
> 3) In SVM, "svm_x86_ops.pmu_ops = &amd_pmu_ops".
> 
> Common kvm_pmu_xxxx functions (in pmu.c) will change accordingly
> afterwards. If no objection, I will do this way.

Yeah, thats probably the best solution then. Extending kvm_init would be
a lot more hassle.


	Joerg