Re: [PATCH] staging: wilc1000: modify odd print message

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Jun 11, 2015 at 12:44:24PM +0900, Dean Lee wrote:
> This driver has odd message in print string.
> So this patch removes the data type.
> 
> Signed-off-by: Dean Lee <dean.lee@atmel.com>
> ---
>  drivers/staging/wilc1000/host_interface.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 1ecb373..9e055c4 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -703,7 +703,7 @@ static WILC_Sint32 Handle_SetOperationMode(void *drvHandler, tstrHostIfSetOperat
>  	strWID.s32ValueSize = sizeof(WILC_Uint32);
>  
>  	/*Sending Cfg*/
> -	PRINT_INFO(HOSTINF_DBG, "(size_t)pstrWFIDrv= %p \n", pstrWFIDrv);
> +	PRINT_INFO(HOSTINF_DBG, "pstrWFIDrv= %p \n", pstrWFIDrv);

Why are you printing a kernel pointer to userspace always?  That's not a
good idea, why not just delete this line, how useful is it?

thanks,

greg k-h