From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Z2tae-0002iR-QC for mharc-grub-devel@gnu.org; Wed, 10 Jun 2015 23:55:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2tac-0002iJ-8C for grub-devel@gnu.org; Wed, 10 Jun 2015 23:55:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2taZ-0005TO-0v for grub-devel@gnu.org; Wed, 10 Jun 2015 23:55:38 -0400 Received: from mail-la0-x243.google.com ([2a00:1450:4010:c03::243]:34533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2taY-0005SB-Oq for grub-devel@gnu.org; Wed, 10 Jun 2015 23:55:34 -0400 Received: by labgd6 with SMTP id gd6so7460553lab.1 for ; Wed, 10 Jun 2015 20:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=yXIXqFEYoXUld2CgQ5b2EMpPI7CJP54q+haXbRjSa7g=; b=iKy8KoIHf6Auuax5l1o5LEP5DRKO0ZygCZ2PXLrMU5hrlt3D3qgvtj+uV+mZsCpIfU WSfLyr3esuqM/nCbpAcN1UJFYGOIs2S6gpDuNR5GpahH4TpL72G7g6i6cJ2CGUyQKmJZ YB4+U76cUaXQadwFmK2+vkLXdNXIpScNlfBmc8rjM2jYYRPWCkpo4rVnbm36f8H952Aa gFOC4xU4HGoKMPmrdNQIovdGLqjGmQaXU2vIIy1xUjJssdluGArvljb2tAUF/vroD77/ NsiaXeLTH/9n61dbBNO8AUFQJwIQJhU0ZjqwgyNLf74K4PVCXOJE4pHN744O3M+wyvKM wcVA== X-Received: by 10.112.222.133 with SMTP id qm5mr7615945lbc.86.1433994933833; Wed, 10 Jun 2015 20:55:33 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id fb5sm2707951lbc.35.2015.06.10.20.55.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jun 2015 20:55:32 -0700 (PDT) Date: Thu, 11 Jun 2015 06:55:31 +0300 From: Andrei Borzenkov To: The development of GRUB 2 Subject: Re: [PATCH] broken ESC navigation if authentication is used Message-ID: <20150611065531.47ffab1f@opensuse.site> In-Reply-To: References: <201506101829.59882.florian_kaiser@genua.de> <20150610223152.1c2f2564@opensuse.site> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.28; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::243 Cc: Florian Kaiser X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2015 03:55:39 -0000 =D0=92 Wed, 10 Jun 2015 21:35:51 +0200 "Vladimir 'phcoder' Serbinenko" =D0=BF=D0=B8=D1=88=D0= =B5=D1=82: > This patch may allow to escape to shell if menu was called from context > without menu entries. This may happen inadvertently I.a. when using > configfile. You need to add an additional parameter to indicate whether > it's OK to break from menu Could you explain? Grub does grub_enter_normal grub_normal_execute grub_show_menu grub_cmdline_run if after processing config file there are no menu entries we do not even call grub_show_menu. And even if we do, after return from it there is mandatory authentication in grub_cmdline_run. I see how it could happen in original commit when authentication was added, but I miss code path that cause it now.=20 > Le 10 juin 2015 21:32, "Andrei Borzenkov" a =C3=A9c= rit : >=20 > > =D0=92 Wed, 10 Jun 2015 18:29:59 +0200 > > Florian Kaiser =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > > > > Hi, > > > > > > we are using grub2 with authentication enabled and multiple submenus. > > > Unfortunately it is not possible to return to a previous menu with ESC > > without > > > triggering a superuser password prompt. This is not the desired behav= ior > > in > > > my opinion. > > > I attached a patch to this email, which removes the password prompt w= hen > > > pressing escape. > > > > > > > Looks OK; I'm not sure why this was needed in the first place - it does > > not look like it is even possible to exit primary menu. > > > > Vladimir, OK to commit? > > > > _______________________________________________ > > Grub-devel mailing list > > Grub-devel@gnu.org > > https://lists.gnu.org/mailman/listinfo/grub-devel > >