From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/bridge/ptn3460: add include for gpiod* Date: Thu, 11 Jun 2015 09:13:10 +0200 Message-ID: <20150611071308.GA19549@ulmo.nvidia.com> References: <1433169812-29189-1-git-send-email-u.kleine-koenig@pengutronix.de> <20150605144623.GA7327@ulmo.nvidia.com> <20150608094517.GB18985@pengutronix.de> <20150610071525.GN18985@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0275923354==" Return-path: Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com [216.228.121.143]) by gabe.freedesktop.org (Postfix) with ESMTP id 930E06E253 for ; Thu, 11 Jun 2015 00:13:50 -0700 (PDT) In-Reply-To: <20150610071525.GN18985@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Geert Uytterhoeven , kernel@pengutronix.de, Ajay Kumar , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0275923354== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd" Content-Disposition: inline --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 10, 2015 at 09:15:25AM +0200, Uwe Kleine-K=C3=B6nig wrote: > Hello, >=20 > Cc +=3D dri-devel@lists.freedesktop.org + kernel@pengutronix.de, forgot > that for the original submission. Also added (hopefully the right) > Geert. >=20 > On Mon, Jun 08, 2015 at 11:45:17AM +0200, Uwe Kleine-K=C3=B6nig wrote: > > Hello, > >=20 > > On Fri, Jun 05, 2015 at 04:46:25PM +0200, Thierry Reding wrote: > > > On Mon, Jun 01, 2015 at 04:43:32PM +0200, Uwe Kleine-K=C3=B6nig wrote: > > > > This fixes: > > > >=20 > > > > CC drivers/gpu/drm/bridge/ptn3460.o > > > > drivers/gpu/drm/bridge/ptn3460.c: In function =E2=80=98ptn3460_pre= _enable=E2=80=99: > > > > drivers/gpu/drm/bridge/ptn3460.c:135:2: error: implicit declaratio= n of function =E2=80=98gpiod_set_value=E2=80=99 [-Werror=3Dimplicit-functio= n-declaration] > > > > gpiod_set_value(ptn_bridge->gpio_pd_n, 1); > > > > ^ > > > > drivers/gpu/drm/bridge/ptn3460.c: In function =E2=80=98ptn3460_pro= be=E2=80=99: > > > > drivers/gpu/drm/bridge/ptn3460.c:333:2: error: implicit declaratio= n of function =E2=80=98devm_gpiod_get=E2=80=99 [-Werror=3Dimplicit-function= -declaration] > > > > ptn_bridge->gpio_pd_n =3D devm_gpiod_get(&client->dev, "powerdow= n"); > > > > ^ > > > > drivers/gpu/drm/bridge/ptn3460.c:333:24: warning: assignment makes= pointer from integer without a cast > > > > ptn_bridge->gpio_pd_n =3D devm_gpiod_get(&client->dev, "powerdow= n"); > > > > ^ > > > > drivers/gpu/drm/bridge/ptn3460.c:340:2: error: implicit declaratio= n of function =E2=80=98gpiod_direction_output=E2=80=99 [-Werror=3Dimplicit-= function-declaration] > > > > ret =3D gpiod_direction_output(ptn_bridge->gpio_pd_n, 1); > > > > ^ > > > > drivers/gpu/drm/bridge/ptn3460.c:346:25: warning: assignment makes= pointer from integer without a cast > > > > ptn_bridge->gpio_rst_n =3D devm_gpiod_get(&client->dev, "reset"); > > > > ^ > > > >=20 > > > > Fixes: af478d8823a7 ("drm/bridge: ptn3460: use gpiod interface") > > > > Signed-off-by: Uwe Kleine-K=C3=B6nig > > > > --- > > > > drivers/gpu/drm/bridge/ptn3460.c | 1 + > > > > 1 file changed, 1 insertion(+) > > >=20 > > > Geert had sent similar patches a while ago, so I applied his instead. > > I didn't find where you applied it. Did you send this patch to Linus for > > 4.1? > If you want to get this into 4.1 it's about time to send it to Linus. Or > don't you consider it that urgent? This build error is triggered by somewhat artificial configuration options and it's been present since v4.0, so I don't think it qualifies as that urgent. It's in linux-next and should make it into v4.2. Thierry --ZPt4rx8FFjLCG7dd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVeTUBAAoJEN0jrNd/PrOhrk8P/2hRUJb49Y6ybCk5OHkDiVyI vNZVQphwqQ9Nt8muGZ6LQQHjOUc8IIHCwXJch1V1mubZrSr5dLEgvV1fJZv01he2 kU+VhczkXlICJehjG30sGSXRwBERyD4v4+e1am+GwglR+FL4XeJMFrGAUPpoi7Zt yeFdj3vFw/aSYO84FwGZO1i9KDZz9RLLdhQ15ULmI2VXZDf1ZOOzUFKkyKTOuUTv gNth796jBWCwpW9makqUYUfdX6BKaeJcjTWy/nyAfQy1DgszZv16ZPJlvN8x819Q 4GKf/DA4C8oaXhYAuzMt0i+oruSrHEUPvffOGqYiwcAF0WlXSMCzvV3nXrDhfFNu 34V8J3rqUpKqCAr7Hq/tHp5NHQdLFIPXhmrEmlslLcepyilkmjSt+2wLjIAacmdj E332RvjXRLEqL3gjNiNqSq3ROHiMR4HeJGMKhcnCJz2eF3iEUqRlOfzS2gR1T3eI 9DjHSpRng8bbEcIG+xeGyo8gkP+SWTCl0/f/MZ8avXljm5YQRB0JPqjAnu3Vk17T pwa3Mt0PmB2W4DrjlYPCq6DQlvi8jM+ehMq2G9oVMOqCQLF20e1MWQBaGIWY9AeP qvCttyLRrhQdCl6iIOzdfBiExovwadeof++K6NYgJjVVu7S/q5OTqOlTBkoqlDMQ nQ4P0ecV+j//OJMmI7AS =D2JU -----END PGP SIGNATURE----- --ZPt4rx8FFjLCG7dd-- --===============0275923354== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0275923354==--