From: Christoph Hellwig <hch@infradead.org>
To: Kinglong Mee <kinglongmee@gmail.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
Weston Andros Adamson <dros@primarydata.com>,
"J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: [PATCH 1/2] nfs: Only update callback sequnce id when CB_SEQUENCE success
Date: Thu, 11 Jun 2015 01:20:28 -0700 [thread overview]
Message-ID: <20150611082028.GA11330@infradead.org> (raw)
In-Reply-To: <5578E67C.1030303@gmail.com>
Hi Kinglong,
when we last brought up this issue the recommendation was to follow
the model in the clients nfs41_sequence_done() which handles even
more corner cases. Given that my previous fixes in that area were
just a bandaid I probably shouldn't complain about piece mail handling,
but if you have a little spare time available implementing the full
set of checks might be worthwhile.
next prev parent reply other threads:[~2015-06-11 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 10:58 [PATCH 1/2] nfs: Only update callback sequnce id when CB_SEQUENCE success Kinglong Mee
2015-06-11 1:38 ` Kinglong Mee
2015-06-11 8:20 ` Christoph Hellwig [this message]
2015-06-11 9:13 ` Kinglong Mee
2015-06-12 1:35 ` [PATCH] NFS: Ensure that we update the sequence id under the slot table lock Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611082028.GA11330@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=dros@primarydata.com \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.