All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Lespiau <damien.lespiau@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/bxt: fix DDI PHY vswing scale value setting
Date: Thu, 11 Jun 2015 11:34:07 +0100	[thread overview]
Message-ID: <20150611103406.GD20020@strange.ger.corp.intel.com> (raw)
In-Reply-To: <20150610161829.GD15024@intel.com>

On Wed, Jun 10, 2015 at 09:18:29AM -0700, Matt Roper wrote:
> On Thu, Jun 04, 2015 at 06:01:35PM +0300, Imre Deak wrote:
> > According to bspec the DDI PHY vswing scale value is "don't care" in
> > case the scale enable bit [27] is clear. But this doesn't seem to be
> > correct. The scale value seems to also matter if the scale mode bit
> > [26] is set. So both bit 26 and 27 depend on the value. Setting the
> > scale value to 0 while either bit is set results in a failed modeset on
> > HDMI (sink reports no signal).
> > 
> > After reset the scale value is 0x98, but according to the spec we have
> > to program it to 0x9a. So for consistency program it always to 0x9a
> > regardless of the scale enable bit.
> > 
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> 
> This patch successfully enables HDMI display for my team.
> 
> Tested-by: Matt Roper <matthew.d.roper@intel.com>

I believe this should be enough of a good reason for merging at this
stage.

Acked-by: Damien Lespiau <damien.lespiau@intel.com>

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-06-11 10:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-04 15:01 [PATCH] drm/i915/bxt: fix DDI PHY vswing scale value setting Imre Deak
2015-06-05  9:22 ` shuang.he
2015-06-10 16:18 ` Matt Roper
2015-06-11 10:34   ` Damien Lespiau [this message]
2015-06-12  7:48     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150611103406.GD20020@strange.ger.corp.intel.com \
    --to=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.