From: hch@infradead.org (Christoph Hellwig)
Subject: abort question
Date: Thu, 11 Jun 2015 06:24:46 -0700 [thread overview]
Message-ID: <20150611132446.GA21761@infradead.org> (raw)
In-Reply-To: <20150611131254.GM2729@linux.intel.com>
On Thu, Jun 11, 2015@09:12:54AM -0400, Matthew Wilcox wrote:
> On Thu, Jun 11, 2015@03:46:03AM -0700, Christoph Hellwig wrote:
> > Don't we need to reserve a request and SQ entry to that we can
> > always send an abort? Otherwise a lockded up controller will never
> > send a abort and always just reset the timer, and never escalate
> > to a controller reset.
>
> Aborts are sent on the admin queue, not the IO queue. There should
> always be plenty of space on the admin queue.
The default admin queue has 256 entries, of which we reserve one for the
AEN command. I've been hacking up a NVMe command fuzzer that sends
semi-random [1] commands to a device, and I manage to reproduce a case
where it seems like aborts don't make progress. I haven't fully sorted
it out yet, but it seems like aborts don't happen.
[1] I had to black list commands like I/O CQ/SQ deletion as that crashes
the driver pretty reliably.
next prev parent reply other threads:[~2015-06-11 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 10:46 abort question Christoph Hellwig
2015-06-11 13:12 ` Matthew Wilcox
2015-06-11 13:24 ` Christoph Hellwig [this message]
2015-06-11 15:44 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611132446.GA21761@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.