From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Amir Vadai <amirv-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Tal Alon <talal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH for-next V3 0/8] Add completion timestamping support
Date: Thu, 11 Jun 2015 11:53:07 -0600 [thread overview]
Message-ID: <20150611175307.GA20142@obsidianresearch.com> (raw)
In-Reply-To: <1434029727-6062-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On Thu, Jun 11, 2015 at 04:35:19PM +0300, Or Gerlitz wrote:
> Jason had another comment calling for re-thinking / questioning the
> need for a dedicated uverbs_ex_cmd_mask in the IB device. This goes
> beyond the scope of this specific series.
How is properly setting up the new verbs you added beyond the scope of
this series? It is a trivial change to move this:
+ ibdev->ib_dev.uverbs_ex_cmd_mask |=
+ (1ull << IB_USER_VERBS_EX_CMD_QUERY_DEVICE) |
+ (1ull << IB_USER_VERBS_EX_CMD_CREATE_CQ);
Into the right core function so it is enabled for all drivers.
That isn't re thinking at all, that is how the extension mechanism was
always intended to work.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-06-11 17:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 13:35 [PATCH for-next V3 0/8] Add completion timestamping support Or Gerlitz
[not found] ` <1434029727-6062-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-06-11 13:35 ` [PATCH for-next V3 1/8] IB/core: Change provider's API of create_cq to be extendible Or Gerlitz
[not found] ` <1434029727-6062-2-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-06-11 17:55 ` Jason Gunthorpe
[not found] ` <20150611175555.GB20142-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-06-12 3:06 ` Or Gerlitz
[not found] ` <CAJ3xEMgA0UorV3ERz_M7-H0Z4c6tmK2e_k84c6VExhzjQJ+9LQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-27 17:11 ` Christoph Lameter
2015-06-11 13:35 ` [PATCH for-next V3 2/8] IB/core: Change ib_create_cq to use struct ib_cq_init_attr Or Gerlitz
2015-06-11 13:35 ` [PATCH for-next V3 3/8] IB/core: Add CQ creation time-stamping flag Or Gerlitz
2015-06-11 13:35 ` [PATCH for-next V3 4/8] IB/core: Extend ib_uverbs_create_cq Or Gerlitz
2015-06-11 13:35 ` [PATCH for-next V3 5/8] IB/core: Add timestamp_mask and hca_core_clock to query_device Or Gerlitz
2015-06-11 13:35 ` [PATCH for-next V3 6/8] IB/core: Pass hardware specific data in query_device Or Gerlitz
2015-06-11 13:35 ` [PATCH for-next V3 7/8] IB/mlx4: Add mmap call to map the hardware clock Or Gerlitz
[not found] ` <1434029727-6062-8-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-08-27 17:11 ` Christoph Lameter
2015-06-11 13:35 ` [PATCH for-next V3 8/8] IB/mlx4: Add support for CQ time-stamping Or Gerlitz
2015-06-11 17:53 ` Jason Gunthorpe [this message]
[not found] ` <20150611175307.GA20142-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-06-12 3:10 ` [PATCH for-next V3 0/8] Add completion timestamping support Or Gerlitz
2015-06-12 19:53 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611175307.GA20142@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=amirv-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=talal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.