From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, Julia Lawall <Julia.Lawall@lip6.fr>,
Ferruh Yigit <fery@cypress.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 1/1 linux-next] Input: cyttsp4 - use swap() in cyttsp4_get_touch()
Date: Thu, 11 Jun 2015 13:08:44 -0700 [thread overview]
Message-ID: <20150611200844.GA10293@dtor-pixel> (raw)
In-Reply-To: <1433953903-23653-1-git-send-email-fabf@skynet.be>
On Wed, Jun 10, 2015 at 06:31:43PM +0200, Fabian Frederick wrote:
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Applied, thank you.
> ---
> drivers/input/touchscreen/cyttsp4_core.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/input/touchscreen/cyttsp4_core.c b/drivers/input/touchscreen/cyttsp4_core.c
> index 568a3d3..5ed3105 100644
> --- a/drivers/input/touchscreen/cyttsp4_core.c
> +++ b/drivers/input/touchscreen/cyttsp4_core.c
> @@ -775,7 +775,6 @@ static void cyttsp4_get_touch(struct cyttsp4_mt_data *md,
> struct device *dev = &md->input->dev;
> struct cyttsp4_sysinfo *si = md->si;
> enum cyttsp4_tch_abs abs;
> - int tmp;
> bool flipped;
>
> for (abs = CY_TCH_X; abs < CY_TCH_NUM_ABS; abs++) {
> @@ -790,9 +789,7 @@ static void cyttsp4_get_touch(struct cyttsp4_mt_data *md,
> }
>
> if (md->pdata->flags & CY_FLAG_FLIP) {
> - tmp = touch->abs[CY_TCH_X];
> - touch->abs[CY_TCH_X] = touch->abs[CY_TCH_Y];
> - touch->abs[CY_TCH_Y] = tmp;
> + swap(touch->abs[CY_TCH_X], touch->abs[CY_TCH_Y]);
> flipped = true;
> } else
> flipped = false;
> --
> 2.4.2
>
prev parent reply other threads:[~2015-06-11 20:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 16:31 [PATCH 1/1 linux-next] Input: cyttsp4 - use swap() in cyttsp4_get_touch() Fabian Frederick
2015-06-11 20:08 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611200844.GA10293@dtor-pixel \
--to=dmitry.torokhov@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=fabf@skynet.be \
--cc=fery@cypress.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.