All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-mml@vger.kernel.org, Andy Lutomirski <luto@amacapital.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	Brian Gerst <brgerst@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
	Oleg Nesterov <oleg@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Waiman Long <Waiman.Long@hp.com>
Subject: Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code
Date: Fri, 12 Jun 2015 09:23:02 +0200	[thread overview]
Message-ID: <20150612072302.GA7509@gmail.com> (raw)
In-Reply-To: <CA+55aFyDp_B9q4ReiMsngzQYTWRukrNBYy7uoGfFQ5nVredT9Q@mail.gmail.com>


* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Thu, Jun 11, 2015 at 1:37 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Don't use "for_each_process_thread(g, p)". You only care about each mm, and 
> > threads all share the same mm, so just do
> >
> >     for_each_process(p)
> >
> > instead of iterating over all threads too.
> 
> Hmm. I may be wrong. It strikes me that one of the group leaders might have 
> exited but the subthreads live on. We'd see p->mm being NULL, even though the mm 
> was originally in use.
> 
> Ugh. So maybe the code really does need to iterate over all threads.

Yeah, for_each_process() is indeed no guarantee that we iterate over all mm's.

We might make it so: but that would mean restricting certain clone_flags variants 
- not sure that's possible with our current ABI usage?

Thanks,

	Ingo

  reply	other threads:[~2015-06-12  7:23 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11 14:07 [RFC PATCH 00/12] x86/mm: Implement lockless pgd_alloc()/pgd_free() Ingo Molnar
2015-06-11 14:07 ` [PATCH 01/12] x86/mm/pat: Don't free PGD entries on memory unmap Ingo Molnar
2015-06-11 14:07 ` [PATCH 02/12] x86/mm/hotplug: Remove pgd_list use from the memory hotplug code Ingo Molnar
2015-06-12 22:22   ` Oleg Nesterov
2015-06-12 22:48   ` Waiman Long
2015-06-13  7:46     ` Ingo Molnar
2015-06-12 23:15   ` Oleg Nesterov
2015-06-13  7:48     ` Ingo Molnar
2015-06-11 14:07 ` [PATCH 03/12] x86/mm/hotplug: Don't remove PGD entries in remove_pagetable() Ingo Molnar
2015-06-11 14:07 ` [PATCH 04/12] x86/mm/hotplug: Simplify sync_global_pgds() Ingo Molnar
2015-06-12 22:28   ` Oleg Nesterov
2015-06-13  7:51     ` Ingo Molnar
2015-06-11 14:07 ` [PATCH 05/12] mm: Introduce arch_pgd_init_late() Ingo Molnar
2015-06-11 18:23   ` Andrew Morton
2015-06-12  8:16     ` Ingo Molnar
2015-06-12 21:12   ` Oleg Nesterov
2015-06-13  6:54     ` Ingo Molnar
2015-06-11 14:07 ` [PATCH 06/12] x86/mm: Enable and use the arch_pgd_init_late() method Ingo Molnar
2015-06-11 20:04   ` Boris Ostrovsky
2015-06-12  8:19     ` Ingo Molnar
2015-06-12 22:50   ` Oleg Nesterov
2015-06-12 22:57     ` Oleg Nesterov
2015-06-13  6:49       ` Ingo Molnar
2015-06-13  6:47     ` Ingo Molnar
2015-06-13  6:52       ` Ingo Molnar
2015-06-13 17:45         ` Oleg Nesterov
2015-06-14  8:13           ` Ingo Molnar
2015-06-14 20:54             ` Oleg Nesterov
2015-06-14 22:10               ` Oleg Nesterov
2015-06-11 14:07 ` [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code Ingo Molnar
2015-06-11 20:37   ` Linus Torvalds
2015-06-11 20:41     ` Linus Torvalds
2015-06-12  7:23       ` Ingo Molnar [this message]
     [not found]         ` <CA+55aFxXM=DN32JqNmJ=JoMum5OPnsRohCry-=2T=LabX2hzVQ@mail.gmail.com>
2015-06-12  8:04           ` Ingo Molnar
2015-06-12 20:38             ` Oleg Nesterov
2015-06-12 20:53               ` Oleg Nesterov
2015-06-12 22:30                 ` Boris Ostrovsky
2015-06-12 23:36                   ` Oleg Nesterov
2015-06-13  7:26               ` Ingo Molnar
2015-06-13 18:00                 ` Oleg Nesterov
2015-06-11 14:07 ` [PATCH 08/12] x86/mm: Remove pgd_list use from vmalloc_sync_all() Ingo Molnar
2015-06-11 15:04   ` Andy Lutomirski
2015-06-11 15:49     ` Ingo Molnar
2015-06-11 16:10       ` Andy Lutomirski
2015-06-11 14:07 ` [PATCH 09/12] x86/mm/pat/32: Remove pgd_list use from the PAT code Ingo Molnar
2015-06-11 14:07 ` [PATCH 10/12] x86/mm: Make pgd_alloc()/pgd_free() lockless Ingo Molnar
2015-06-11 14:07 ` [PATCH 11/12] x86/mm: Remove pgd_list leftovers Ingo Molnar
2015-06-11 14:07 ` [PATCH 12/12] x86/mm: Simplify pgd_alloc() Ingo Molnar
2015-06-11 14:13 ` [RFC PATCH 00/12] x86/mm: Implement lockless pgd_alloc()/pgd_free() Ingo Molnar
2015-06-11 14:13   ` Ingo Molnar
2015-06-11 16:46 ` H. Peter Anvin
  -- strict thread matches above, loose matches on Subject: below --
2015-06-13  9:49 [PATCH 00/12, v2] " Ingo Molnar
2015-06-13  9:49 ` [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code Ingo Molnar
2015-06-13  9:49   ` Ingo Molnar
2015-06-14  8:26   ` Ingo Molnar
2015-06-14  8:26     ` Ingo Molnar
2015-06-15  9:05   ` Ian Campbell
2015-06-15  9:05   ` Ian Campbell
2015-06-15  9:05     ` Ian Campbell
2015-06-15 10:30     ` David Vrabel
2015-06-15 10:30     ` David Vrabel
2015-06-15 10:30       ` David Vrabel
2015-06-15 20:35       ` Ingo Molnar
2015-06-15 20:35       ` Ingo Molnar
2015-06-15 20:35         ` Ingo Molnar
2015-06-16 14:15         ` David Vrabel
2015-06-16 14:15           ` David Vrabel
2015-06-16 14:19           ` Boris Ostrovsky
2015-06-16 14:19           ` Boris Ostrovsky
2015-06-16 14:19             ` Boris Ostrovsky
2015-06-16 14:27             ` David Vrabel
2015-06-16 14:27               ` David Vrabel
2015-06-16 14:27             ` David Vrabel
2015-06-16 14:15         ` David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150612072302.GA7509@gmail.com \
    --to=mingo@kernel.org \
    --cc=Waiman.Long@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dvlasenk@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mml@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.