From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754377AbbFLHjJ (ORCPT <rfc822;w@1wt.eu>);
	Fri, 12 Jun 2015 03:39:09 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:37653 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753540AbbFLHjE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 12 Jun 2015 03:39:04 -0400
Date: Fri, 12 Jun 2015 09:38:48 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Huang Rui <ray.huang@amd.com>
Cc: Andy Lutomirski <luto@amacapital.net>, Borislav Petkov <bp@suse.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>,
        John Stultz <john.stultz@linaro.org>,
        =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker <fweisbec@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        X86 ML <x86@kernel.org>, Fengguang Wu <fengguang.wu@intel.com>,
        Aaron Lu <aaron.lu@intel.com>,
        Suravee Suthikulanit <suravee.suthikulpanit@amd.com>,
        Tony Li <tony.li@amd.com>, Ken Xue <ken.xue@amd.com>
Subject: Re: [PATCH v3 2/2] x86, mwaitt: introduce mwaix delay with a
 configurable timer
Message-ID: <20150612073848.GQ3644@twins.programming.kicks-ass.net>
References: <1434032051-1953-1-git-send-email-ray.huang@amd.com>
 <1434032051-1953-3-git-send-email-ray.huang@amd.com>
 <CALCETrW6ZOTE7JcTQsNhJex5eaVQ8+z7MVGG-pfCOj=e47o10w@mail.gmail.com>
 <20150612040322.GB21621@hr-slim.amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150612040322.GB21621@hr-slim.amd.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 12, 2015 at 12:03:22PM +0800, Huang Rui wrote:

> > What's the purpose of the "enable" parameter?
> > 
> 
> Enable mwaitx timer. Should I add comments to explain the usage?

No, you should read your own patch, notice that the only usage site
provides a true, then realize its a redundant bit of code and kill it
dead.