From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751651AbbFLIfh (ORCPT ); Fri, 12 Jun 2015 04:35:37 -0400 Received: from mail-bl2on0115.outbound.protection.outlook.com ([65.55.169.115]:62265 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751067AbbFLIfc (ORCPT ); Fri, 12 Jun 2015 04:35:32 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; amacapital.net; dkim=none (message not signed) header.d=none; X-WSS-ID: 0NPTP6Z-08-4P0-02 X-M-MSG: Date: Fri, 12 Jun 2015 16:23:21 +0800 From: Huang Rui To: Borislav Petkov CC: Peter Zijlstra , Andy Lutomirski , Thomas Gleixner , "Rafael J. Wysocki" , Len Brown , John Stultz , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , "linux-kernel@vger.kernel.org" , X86 ML , Fengguang Wu , Aaron Lu , Suravee Suthikulanit , Tony Li , Ken Xue Subject: Re: [PATCH v3 2/2] x86, mwaitt: introduce mwaix delay with a configurable timer Message-ID: <20150612082320.GA24776@hr-slim.amd.com> References: <1434032051-1953-1-git-send-email-ray.huang@amd.com> <1434032051-1953-3-git-send-email-ray.huang@amd.com> <20150612040322.GB21621@hr-slim.amd.com> <20150612073848.GQ3644@twins.programming.kicks-ass.net> <20150612075033.GA24767@hr-slim.amd.com> <20150612083033.GA9257@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150612083033.GA9257@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD049;1:FTM4rZID8cxLkrpuk4ZKC2ZSicA47SGTvhy/WS9zamfBjS/m7vcJHxCoSqbQlh/xoAHhi7h7ZUB6ikR9prp3e75aLL3R1O8HgHlQWGAXifXYpkqPmEhz+BeoS8WJCpxT7PdvgAmhP2JK0SFRhDYMkh8DyjMCcWgDEUesfV49sLb3eflzcpowwOWYgDRxarJVZWJ+BwR/ObWAN7zvhZTedmZ816U3JNiwAdyi0C2pv1kHskQswlt/bvEGfwULJYT94VemWY8u3NH1o3X3FJcrsHt7DFpNxPGsBKp+T98E0NEyWe8a2ifebdObLlqK9dIEXtomPvucOmFXKXBooTlXi+n+zW0JJkZ0SatyUFcOrcU= X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(24454002)(199003)(164054003)(51704005)(189002)(47776003)(50466002)(23726002)(50986999)(106466001)(105586002)(33656002)(46102003)(97756001)(4001350100001)(5003600100002)(77096005)(189998001)(2950100001)(5001920100001)(110136002)(87936001)(101416001)(54356999)(92566002)(62966003)(93886004)(53416004)(83506001)(76176999)(77156002)(86362001)(46406003);DIR:OUT;SFP:1102;SCL:1;SRVR:BN1PR02MB070;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB070; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(520003)(3002001);SRVR:BN1PR02MB070;BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB070; X-Forefront-PRVS: 060503E79B X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2015 08:35:27.7350 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR02MB070 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 12, 2015 at 10:30:33AM +0200, Borislav Petkov wrote: > On Fri, Jun 12, 2015 at 03:50:33PM +0800, Huang Rui wrote: > > Yeah, but I remembered at last time, someone tell me we shouldn't > > force to set timer always enabled. So I add this interface to expose > > more clearly. :) > > Yeah, but this interface would make users go and look at it and try to > remember what the enable parameter stood for. > > > So could I use __mwaitx directly like below: > > > > __monitorx(&dummy, 0, 0); > > __mwaitx(0xf, delay, MWAITX_ECX_TIMER_ENABLE); > > Yes, this is more straight-forward and what the hardware instructions > take, so more intuitive. > OK, will do it. :) Thanks, Rui