From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751173AbbFLIas (ORCPT <rfc822;w@1wt.eu>);
	Fri, 12 Jun 2015 04:30:48 -0400
Received: from cantor2.suse.de ([195.135.220.15]:45777 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750781AbbFLIan (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 12 Jun 2015 04:30:43 -0400
Date: Fri, 12 Jun 2015 10:30:33 +0200
From: Borislav Petkov <bp@suse.de>
To: Huang Rui <ray.huang@amd.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>,
        John Stultz <john.stultz@linaro.org>,
        =?utf-8?B?RnLDqWTDqXJpYw==?= Weisbecker <fweisbec@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        X86 ML <x86@kernel.org>, Fengguang Wu <fengguang.wu@intel.com>,
        Aaron Lu <aaron.lu@intel.com>,
        Suravee Suthikulanit <suravee.suthikulpanit@amd.com>,
        Tony Li <tony.li@amd.com>, Ken Xue <ken.xue@amd.com>
Subject: Re: [PATCH v3 2/2] x86, mwaitt: introduce mwaix delay with a
 configurable timer
Message-ID: <20150612083033.GA9257@pd.tnic>
References: <1434032051-1953-1-git-send-email-ray.huang@amd.com>
 <1434032051-1953-3-git-send-email-ray.huang@amd.com>
 <CALCETrW6ZOTE7JcTQsNhJex5eaVQ8+z7MVGG-pfCOj=e47o10w@mail.gmail.com>
 <20150612040322.GB21621@hr-slim.amd.com>
 <20150612073848.GQ3644@twins.programming.kicks-ass.net>
 <20150612075033.GA24767@hr-slim.amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150612075033.GA24767@hr-slim.amd.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 12, 2015 at 03:50:33PM +0800, Huang Rui wrote:
> Yeah, but I remembered at last time, someone tell me we shouldn't
> force to set timer always enabled. So I add this interface to expose
> more clearly. :)

Yeah, but this interface would make users go and look at it and try to
remember what the enable parameter stood for.

> So could I use __mwaitx directly like below:
> 
> __monitorx(&dummy, 0, 0);
> __mwaitx(0xf, delay, MWAITX_ECX_TIMER_ENABLE);

Yes, this is more straight-forward and what the hardware instructions
take, so more intuitive.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--