From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Z3IhK-0005E3-5J for mharc-grub-devel@gnu.org; Fri, 12 Jun 2015 02:44:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3IhI-0005Dt-Gl for grub-devel@gnu.org; Fri, 12 Jun 2015 02:44:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3IhF-0001jO-Bn for grub-devel@gnu.org; Fri, 12 Jun 2015 02:44:12 -0400 Received: from mail-lb0-x235.google.com ([2a00:1450:4010:c04::235]:33132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3IhF-0001jF-4G for grub-devel@gnu.org; Fri, 12 Jun 2015 02:44:09 -0400 Received: by lbcue7 with SMTP id ue7so14598712lbc.0 for ; Thu, 11 Jun 2015 23:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; bh=ET+UBNJtaFmP4HDMWjnEsT0mWmbrhWzbCQySe/FzwUA=; b=Hn6GafGgJeeJy/LB2VwFGuZ1H0+5hAtb25ogatHTrrSx8HeVTLf+ZPPUcCFLbwfiqH Jgi7ZqfcMDWdp1Ay+u3h4PPR1sQch22E5ImZG717UonFpcmKVAVUH9FyyIU3Nzf2jk+M p9Zis9xxRRUmL/jDlg+Jh/kkSrSBRq8aOHKieJgjbwj5sJh6JkKgg2PYXNBgGfbAFQHQ LNP+WkbOpW+XTB92F4A+pci9ad2yCr+UUjde7ZaR3In3njI2UbWf05qXQz1sb9owpArS 9/bwS0AaFLn5pdkU7Uu0tJJlqGwVGlEEQRrXbTsqtDsScNEO5zsgrgWjxKMeyfwTEujP c9WA== X-Received: by 10.112.13.97 with SMTP id g1mr13572948lbc.52.1434091448221; Thu, 11 Jun 2015 23:44:08 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id yf5sm650246lab.1.2015.06.11.23.44.07 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jun 2015 23:44:07 -0700 (PDT) Date: Fri, 12 Jun 2015 09:44:03 +0300 From: Andrei Borzenkov To: Paul Menzel Subject: Re: [PATCH v2] disk/ahci.c: Use defines `GRUB_AHCI_HBA_PORT_CMD_SPIN_UP` and `GRUB_AHCI_HBA_PORT_CMD_POWER_ON` Message-ID: <20150612094403.17aba46b@opensuse.site> In-Reply-To: <1433667897.3192.6.camel@users.sourceforge.net> References: <1432835841.3378.47.camel@users.sourceforge.net> <1432836218.3378.50.camel@users.sourceforge.net> <20150531092821.501b70d0@opensuse.site> <1433667897.3192.6.camel@users.sourceforge.net> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.28; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/Vjb.x_MGrEK8eCgYU+95TR9"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::235 Cc: grub-devel@gnu.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2015 06:44:13 -0000 --Sig_/Vjb.x_MGrEK8eCgYU+95TR9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Sun, 07 Jun 2015 11:04:57 +0200 Paul Menzel =D0=BF=D0=B8=D1=88=D0=B5=D1= =82: > Date: Thu, 28 May 2015 19:14:19 +0200 >=20 > Instead of hard coding `2` and `4` use the macros defined already at the > top of the file. As a consequence, wrap the now too long line. > --- > v2: Merge both patches. >=20 applied. > grub-core/disk/ahci.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/grub-core/disk/ahci.c b/grub-core/disk/ahci.c > index 7f75724..fa7aa88 100644 > --- a/grub-core/disk/ahci.c > +++ b/grub-core/disk/ahci.c > @@ -552,7 +552,9 @@ grub_ahci_pciinit (grub_pci_device_t dev, > adevs[i]->hba->ports[adevs[i]->port].sata_error); > =20 > adevs[i]->hba->ports[adevs[i]->port].command > - =3D (adevs[i]->hba->ports[adevs[i]->port].command & 0x0fffffff) | (1 = << 28) | 2 | 4; > + =3D (adevs[i]->hba->ports[adevs[i]->port].command & 0x0fffffff) | (1 = << 28) > + | GRUB_AHCI_HBA_PORT_CMD_SPIN_UP > + | GRUB_AHCI_HBA_PORT_CMD_POWER_ON; > =20 > /* struct grub_disk_ata_pass_through_parms parms2; > grub_memset (&parms2, 0, sizeof (parms2)); --Sig_/Vjb.x_MGrEK8eCgYU+95TR9 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlV6f7YACgkQR6LMutpd94yBbgCdH2LpPE2/ThYI34bVOz93jAut hD0An3/Gk3/4QUr1HyeaoaAjHT+vavmy =kCaS -----END PGP SIGNATURE----- --Sig_/Vjb.x_MGrEK8eCgYU+95TR9--