From: Vinod Koul <vinod.koul@intel.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
gabriel@unseen.is, Marek Szyprowski <m.szyprowski@samsung.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
stable@vger.kernel.org
Subject: Re: [RFT PATCH] dmaengine: Fix choppy sound because of unimplemented resume
Date: Fri, 12 Jun 2015 15:35:33 +0530 [thread overview]
Message-ID: <20150612100533.GG28601@localhost> (raw)
In-Reply-To: <1433924227-28499-1-git-send-email-k.kozlowski@samsung.com>
On Wed, Jun 10, 2015 at 05:17:07PM +0900, Krzysztof Kozlowski wrote:
> Some drivers implement only pause operation (no resuming). Example is
> pl330 where pause is needed for getting residuum. pl330 does not support
> resume operation, transfer must be stopped after pause.
>
> However for slaves this is exposed always as "pause and resume" which
> introduces subtle errors on Odroid U3 board (Exynos4412 with pl330).
> After adding pause function to pl330 driver the audio playback
> (utilizing DMA) gets choppy after some time (approximately 24 hours).
>
> Fix this by exposing "cmd_pause" if and only if pause and resume are
> implemented.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reported-by: gabriel@unseen.is
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: <stable@vger.kernel.org>
> Fixes: 88987d2c7534 ("dmaengine: pl330: add DMA_PAUSE feature")
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2015-06-12 10:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 8:17 [RFT PATCH] dmaengine: Fix choppy sound because of unimplemented resume Krzysztof Kozlowski
2015-06-11 16:23 ` Maxime Ripard
2015-06-12 10:05 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150612100533.GG28601@localhost \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gabriel@unseen.is \
--cc=k.kozlowski@samsung.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maxime.ripard@free-electrons.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.