Re: [PATCH 1/2] MIPS: Loongson: Add support for Loongson3.

[Andrei Borzenkov <arvidjaar@gmail.com>]

В Mon, 8 Jun 2015 17:25:16 +0800
Heiher <r@hev.cc> пишет:

> --- a/grub-core/bus/pci.c
> +++ b/grub-core/bus/pci.c
> @@ -72,7 +72,7 @@ grub_dma_get_virt (struct grub_pci_dma_chunk *ch)
>  grub_uint32_t
>  grub_dma_get_phys (struct grub_pci_dma_chunk *ch)
>  {
> -  return (((grub_uint32_t) ch) & 0x1fffffff) | 0x80000000;
> +  return (((grub_uint32_t) ch) & 0x1fffffff);

I do not have experience with hardware but that does not look right.
Either this chunk breaks existing hardware or this part was not needed
in the first place. I suspect the former because later you re-add the
same code in subsequent patch.

This makes it hard to bisect later as it leaves some commits in
non-functional state.

Could you please rearrange your patches so that they do not impact
existing platforms?