From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [PATCH 1/3] rte_ring: remove deprecated functions
Date: Fri, 12 Jun 2015 15:22:25 +0100 [thread overview]
Message-ID: <20150612142224.GA6032@bricha3-MOBL3> (raw)
In-Reply-To: <3193080.9j8deXXLB3@xps13>
On Fri, Jun 12, 2015 at 04:15:10PM +0200, Thomas Monjalon wrote:
> 2015-06-12 15:00, Bruce Richardson:
> > On Fri, Jun 12, 2015 at 08:46:55AM +0300, Panu Matilainen wrote:
> > > On 06/12/2015 08:18 AM, Stephen Hemminger wrote:
> > Also, patch title should be prefixed with "ring pmd" or "drivers/net/ring" rather
> > than rte_ring, since this is a patch for the ring pmd, not the rte_ring library.
>
> Previously, there was no difference, it was only "ring".
> Prefixes don't include full path nor "pmd".
> Is it really important to make a difference in the commit title between ring lib
> and ring pmd?
Not especially important, no.
However, if we are going to have prefixes to indicate what component is affected
by a patch, they should at least be unique per component IMHO.
/Bruce
next prev parent reply other threads:[~2015-06-12 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 5:18 [PATCH 0/3] do deprecation in 2.1 Stephen Hemminger
2015-06-12 5:18 ` [PATCH 1/3] rte_ring: remove deprecated functions Stephen Hemminger
2015-06-12 5:46 ` Panu Matilainen
2015-06-12 14:00 ` Bruce Richardson
2015-06-12 14:15 ` Thomas Monjalon
2015-06-12 14:22 ` Bruce Richardson [this message]
2015-06-12 5:18 ` [PATCH 2/3] kni: " Stephen Hemminger
2015-06-12 6:20 ` Panu Matilainen
2015-06-15 2:35 ` Zhang, Helin
2015-06-12 5:18 ` [PATCH 3/3] acl: mark " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150612142224.GA6032@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=shemming@brocade.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.