All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Peter Hung <hpeter@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	peter_hong@fintek.com.tw, tom_tsai@fintek.com.tw,
	Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH 1/1] staging:f81534 Add F81532/534 Driver
Date: Fri, 12 Jun 2015 08:29:15 -0700	[thread overview]
Message-ID: <20150612152915.GA30967@kroah.com> (raw)
In-Reply-To: <557A705F.6000003@gmail.com>

On Fri, Jun 12, 2015 at 01:38:39PM +0800, Peter Hung wrote:
> Greg KH 於 2015/6/12 下午 12:33 寫道:
> >Why not just do the work now to clean up the file and get it merged
> >"properly"?  Why put this in staging at all?
> >
> 
> I'll clear up the file and resend it to usb-serial subsystem mail list.

Note, the "custom" ioctls will have to be removed, we can't have them in
a usb-serial driver, sorry.  Use the "real" GPIO api interface instead.

thanks,

greg k-h

      reply	other threads:[~2015-06-12 15:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12  3:43 [PATCH 1/1] staging:f81534 Add F81532/534 Driver Peter Hung
2015-06-12  4:33 ` Greg KH
2015-06-12  5:38   ` Peter Hung
2015-06-12 15:29     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150612152915.GA30967@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hpeter+linux_kernel@gmail.com \
    --cc=hpeter@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter_hong@fintek.com.tw \
    --cc=tom_tsai@fintek.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.