From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/3] vfs, writeback: replace FS_CGROUP_WRITEBACK with MS_CGROUPWB Date: Sat, 13 Jun 2015 09:16:08 -0700 Message-ID: <20150613161608.GA29414@infradead.org> References: <1434146254-26220-1-git-send-email-tj@kernel.org> <1434146254-26220-3-git-send-email-tj@kernel.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <1434146254-26220-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo Cc: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alexander Viro , Jan Kara , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Fri, Jun 12, 2015 at 04:57:33PM -0500, Tejun Heo wrote: > FS_CGROUP_WRITEBACK indicates whether a file_system_type supports > cgroup writeback; however, different super_blocks of the same > file_system_type may or may not support cgroup writeback depending on > filesystem options. This patch replaces FS_CGROUP_WRITEBACK with a > kernel-internal super_block->s_flags MS_CGROUPWB. The concatenated > and abbreviated name is for consistency with other MS_* flags. Nak. As the uapi part makes it obvious the MS_ namespace is part of the userspace ABI. Please add a new in-kernel flags field instead. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753636AbbFMQQQ (ORCPT ); Sat, 13 Jun 2015 12:16:16 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:34065 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbbFMQQK (ORCPT ); Sat, 13 Jun 2015 12:16:10 -0400 Date: Sat, 13 Jun 2015 09:16:08 -0700 From: Christoph Hellwig To: Tejun Heo Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, lizefan@huawei.com, cgroups@vger.kernel.org, Alexander Viro , Jan Kara , linux-ext4@vger.kernel.org Subject: Re: [PATCH 2/3] vfs, writeback: replace FS_CGROUP_WRITEBACK with MS_CGROUPWB Message-ID: <20150613161608.GA29414@infradead.org> References: <1434146254-26220-1-git-send-email-tj@kernel.org> <1434146254-26220-3-git-send-email-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434146254-26220-3-git-send-email-tj@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 12, 2015 at 04:57:33PM -0500, Tejun Heo wrote: > FS_CGROUP_WRITEBACK indicates whether a file_system_type supports > cgroup writeback; however, different super_blocks of the same > file_system_type may or may not support cgroup writeback depending on > filesystem options. This patch replaces FS_CGROUP_WRITEBACK with a > kernel-internal super_block->s_flags MS_CGROUPWB. The concatenated > and abbreviated name is for consistency with other MS_* flags. Nak. As the uapi part makes it obvious the MS_ namespace is part of the userspace ABI. Please add a new in-kernel flags field instead.