From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan McDowell Subject: Re: Audio crackles with 4.1-rc1 Date: Sun, 14 Jun 2015 13:24:20 +0100 Message-ID: <20150614122420.GT28070@earth.li> References: <20150610194303.3b82609d@mdontu-l.dsd.bitdefender.biz> <20150611011236.53bcd1fd@mdontu-l> <20150612012318.6e3482ed@mdontu-l> <20150612124523.37fd0875@mdontu-l> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from the.earth.li (the.earth.li [46.43.34.31]) by alsa0.perex.cz (Postfix) with ESMTP id DD4E326052F for ; Sun, 14 Jun 2015 14:24:22 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Mihai =?utf-8?B?RG9uyJt1?= List-Id: alsa-devel@alsa-project.org T24gRnJpLCBKdW4gMTIsIDIwMTUgYXQgMDQ6MTM6MTZQTSArMDIwMCwgVGFrYXNoaSBJd2FpIHdy b3RlOgo+IEF0IEZyaSwgMTIgSnVuIDIwMTUgMTI6MDk6NTUgKzAyMDAsCj4gVGFrYXNoaSBJd2Fp IHdyb3RlOgo+ID4gQXQgRnJpLCAxMiBKdW4gMjAxNSAxMjo0NToyMyArMDMwMCwKPiA+IE1paGFp IERvbsibdSB3cm90ZToKPiA+ID4gTmljZSBzaG90ISBJdCBhcHBlYXJzIHRvIHdvcmsuIDotKSBO byBjbGlja3MsIG5vIHN0YXRpYy4KPiA+IAo+ID4gR29vZCB0byBoZWFyIQo+ID4gCj4gPiA+IEkg aGFkIHRvIGFwcGx5IGl0IGJ5IGhhbmQgb3ZlciA0LjEtcmM3LCBiZWNhdXNlIHRoZSBmaXJzdCB0 d28gYXJyYXlzCj4gPiA+IGxvb2sgZGlmZmVyZW50IGluIGJvdGggaXQgYW5kIC1tYXN0ZXIuIEFu eXdheSwgSSB3aWxsIHBsYXkgd2l0aCBpdCBzb21lCj4gPiA+IG1vcmUgdG9kYXkgc2VlIGlmIGFu eXRoaW5nIGVsc2UgaXMgYnJva2VuLgo+ID4gCj4gPiBXaGlsZSB3ZSBhcmUgYXQgaXQ6IGNvdWxk IHlvdSB0cnkgdG8gZW5hYmxlIGNvZGVjLT5wb3dlcl9zYXZlX25vZGUgaW4KPiA+IHBhdGNoX2Fs YzI2OSgpICh3aGlsZSBrZWVwaW5nIHRoZSBuZXcgcGF0Y2gpPwo+ID4gCj4gPiAtLS0gYS9zb3Vu ZC9wY2kvaGRhL3BhdGNoX3JlYWx0ZWsuYwo+ID4gKysrIGIvc291bmQvcGNpL2hkYS9wYXRjaF9y ZWFsdGVrLmMKPiA+IEBAIC01NjcxLDggKzU2NzEsNyBAQCBzdGF0aWMgaW50IHBhdGNoX2FsYzI2 OShzdHJ1Y3QgaGRhX2NvZGVjICpjb2RlYykKPiA+ICAKPiA+ICAJc3BlYyA9IGNvZGVjLT5zcGVj Owo+ID4gIAlzcGVjLT5nZW4uc2hhcmVkX21pY192cmVmX3BpbiA9IDB4MTg7Cj4gPiAtCWlmIChj b2RlYy0+Y29yZS52ZW5kb3JfaWQgIT0gMHgxMGVjMDI5MikKPiA+IC0JCWNvZGVjLT5wb3dlcl9z YXZlX25vZGUgPSAxOwo+ID4gKwljb2RlYy0+cG93ZXJfc2F2ZV9ub2RlID0gMTsKPiA+ICAKPiA+ ICAjaWZkZWYgQ09ORklHX1BNCj4gPiAgCWNvZGVjLT5wYXRjaF9vcHMuc3VzcGVuZCA9IGFsYzI2 OV9zdXNwZW5kOwo+IAo+IEZvciB5b3VyIGNvbnZlbmllbmNlLCBiZWxvdyBpcyB0aGUgY29tYmlu ZWQgcGF0Y2ggZm9yIDQuMS4KPiAKPiBKb25hdGhhbiwgY291bGQgeW91IGFsc28gdHJ5IHRoaXMg cGF0Y2ggYW5kIHNlZSB3aGV0aGVyIHlvdSBzdGlsbCBnZXQKPiB0aGUgbm9pc2U/CgpBcHBseWlu ZyB0aGUgY29tYmluZWQgcGF0Y2ggdG8gNC4xLXJjNyBJJ20gbm90IGdldHRpbmcgYW55IG5vaXNl IG9uIHRoZQp0cmFuc2l0aW9uIGZyb20gc3VzcGVuZGVkIHRvIGFjdGl2ZS4KCkouCgotLSAKICAg MTAxIHRoaW5ncyB5b3UgY2FuJ3QgaGF2ZSB0b28gICB8ICAuJydgLiAgRGViaWFuIEdOVS9MaW51 eCBEZXZlbG9wZXIKICAgIG11Y2ggb2YgOiA0NyAtIE1vcmUgY29mZmVlLiAgICB8IDogOicgOiAg SGFwcHkgdG8gYWNjZXB0IFBHUCBzaWduZWQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB8IGAuIGAnICAgb3IgZW5jcnlwdGVkIG1haWwgLSBSU0EKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB8ICAgYC0gICAga2V5IG9uIHRoZSBrZXlzZXJ2ZXJzLgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxp bmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxzYS1w cm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751875AbbFNMYb (ORCPT ); Sun, 14 Jun 2015 08:24:31 -0400 Received: from the.earth.li ([46.43.34.31]:47836 "EHLO the.earth.li" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751060AbbFNMYX (ORCPT ); Sun, 14 Jun 2015 08:24:23 -0400 Date: Sun, 14 Jun 2015 13:24:20 +0100 From: Jonathan McDowell To: Takashi Iwai Cc: Mihai =?utf-8?B?RG9uyJt1?= , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: Audio crackles with 4.1-rc1 Message-ID: <20150614122420.GT28070@earth.li> References: <20150610194303.3b82609d@mdontu-l.dsd.bitdefender.biz> <20150611011236.53bcd1fd@mdontu-l> <20150612012318.6e3482ed@mdontu-l> <20150612124523.37fd0875@mdontu-l> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 12, 2015 at 04:13:16PM +0200, Takashi Iwai wrote: > At Fri, 12 Jun 2015 12:09:55 +0200, > Takashi Iwai wrote: > > At Fri, 12 Jun 2015 12:45:23 +0300, > > Mihai Donțu wrote: > > > Nice shot! It appears to work. :-) No clicks, no static. > > > > Good to hear! > > > > > I had to apply it by hand over 4.1-rc7, because the first two arrays > > > look different in both it and -master. Anyway, I will play with it some > > > more today see if anything else is broken. > > > > While we are at it: could you try to enable codec->power_save_node in > > patch_alc269() (while keeping the new patch)? > > > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -5671,8 +5671,7 @@ static int patch_alc269(struct hda_codec *codec) > > > > spec = codec->spec; > > spec->gen.shared_mic_vref_pin = 0x18; > > - if (codec->core.vendor_id != 0x10ec0292) > > - codec->power_save_node = 1; > > + codec->power_save_node = 1; > > > > #ifdef CONFIG_PM > > codec->patch_ops.suspend = alc269_suspend; > > For your convenience, below is the combined patch for 4.1. > > Jonathan, could you also try this patch and see whether you still get > the noise? Applying the combined patch to 4.1-rc7 I'm not getting any noise on the transition from suspended to active. J. -- 101 things you can't have too | .''`. Debian GNU/Linux Developer much of : 47 - More coffee. | : :' : Happy to accept PGP signed | `. `' or encrypted mail - RSA | `- key on the keyservers.