All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Igor Vuk <parcijala@gmail.com>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, brouer@redhat.com
Subject: Re: [PATCH] pktgen: fix typos in pktgen_bench_xmit_mode_netif_receive.sh
Date: Sun, 14 Jun 2015 18:59:28 +0200	[thread overview]
Message-ID: <20150614185928.3af7d546@redhat.com> (raw)
In-Reply-To: <1434275018-14940-1-git-send-email-parcijala@gmail.com>

On Sun, 14 Jun 2015 11:43:38 +0200
Igor Vuk <parcijala@gmail.com> wrote:

> Fixes some typos in pktgen_bench_xmit_mode_netif_receive.sh,
> also does some minor reformatting so the original layout is
> preserved.
> 
> Signed-off-by: Igor Vuk <parcijala@gmail.com>
> ---
>  samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh b/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh
> index cb15903..a25525e 100755
> --- a/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh
> +++ b/samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh
> @@ -7,9 +7,9 @@
>  # "xmit_mode netif_receive".  With an invalid dst_mac this will only
>  # measure the ingress code path as packets gets dropped in ip_rcv().
>  #
> -# This script don't really need any hardware.  It benchmarks software
> -# RX path just after NIC driver level.  With bursting is also
> -# "removes" the SKB alloc/free overhead.
> +# This script doesn't really need any hardware.  It benchmarks
> +# software RX path just after NIC driver level.  With bursting it
> +# also "removes" the SKB alloc/free overhead.
>  #
>  # Setup scenarios for measuring ingress qdisc (with invalid dst_mac):
>  # ------------------------------------------------------------------
> @@ -69,7 +69,7 @@ for ((thread = 0; thread < $THREADS; thread++)); do
>      # Inject packet into RX path of stack
>      pg_set $dev "xmit_mode netif_receive"
>  
> -    # Burst allow us to avoid measuring SKB alloc/free overhead
> +    # Burst allows us to avoid measuring SKB alloc/free overhead
>      pg_set $dev "burst $BURST"

Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>


-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer

      reply	other threads:[~2015-06-14 16:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-14  9:43 [PATCH] pktgen: fix typos in pktgen_bench_xmit_mode_netif_receive.sh Igor Vuk
2015-06-14 16:59 ` Jesper Dangaard Brouer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150614185928.3af7d546@redhat.com \
    --to=brouer@redhat.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=parcijala@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.