All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Dean.lee" <dean.lee@atmel.com>
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
	johnny.kim@atmel.com, chris.park@atmel.com, rachel.kim@atmel.com
Subject: Re: [PATCH] staging: wilc1000: change WILC_Char to s8
Date: Sun, 14 Jun 2015 19:34:12 -0700	[thread overview]
Message-ID: <20150615023412.GA31318@kroah.com> (raw)
In-Reply-To: <557E2088.10008@atmel.com>

On Mon, Jun 15, 2015 at 09:47:04AM +0900, Dean.lee wrote:
> 
> 
> On 2015년 06월 13일 00:28, Greg KH wrote:
> >On Fri, Jun 12, 2015 at 02:39:08PM +0900, Dean Lee wrote:
> >>change own data type(WILC_Char) to common data type(s8)
> >Why not just 'char'?
> >
> >And you are using these in "strings", so why not u8?
> >
> >thanks,
> >
> >greg k-h
> i research some documents for change to common data type.
> that's saying 's8' is 'signed char'.
> 
> 'WILC_Char' is redefine 'char'. so i changed 'WILC_Char' to 's8'

Then stick to 'char', don't change the type.

thanks,

greg k-h

      parent reply	other threads:[~2015-06-15  2:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12  5:39 [PATCH] staging: wilc1000: change WILC_Char to s8 Dean Lee
2015-06-12 15:28 ` Greg KH
     [not found]   ` <557E2088.10008@atmel.com>
2015-06-15  2:34     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150615023412.GA31318@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chris.park@atmel.com \
    --cc=dean.lee@atmel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=johnny.kim@atmel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rachel.kim@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.