From: Theodore Ts'o <tytso@mit.edu>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: ext4: mballoc: avoid 20-argument function call
Date: Mon, 15 Jun 2015 00:36:05 -0400 [thread overview]
Message-ID: <20150615043605.GA15413@thunk.org> (raw)
In-Reply-To: <1433975282-20694-1-git-send-email-linux@rasmusvillemoes.dk>
On Thu, Jun 11, 2015 at 12:28:02AM +0200, Rasmus Villemoes wrote:
> Making a function call with 20 arguments is rather expensive in both
> stack and .text. In this case, doing the formatting manually doesn't
> make it any less readable, so we might as well save 155 bytes of .text
> and 112 bytes of stack.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Thanks, applied.
- Ted
prev parent reply other threads:[~2015-06-15 4:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 22:28 [PATCH] ext4: mballoc: avoid 20-argument function call Rasmus Villemoes
2015-06-15 4:36 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615043605.GA15413@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.