Re: [PATCH net-next 1/1] - ROSE device usage count

[Ralf Baechle DL5RB <ralf@linux-mips.org>]

On Wed, May 20, 2015 at 05:16:58PM +0200, walter harms wrote:

> > +	if ((dev = rose_dev_get(&addr->srose_addr)) == NULL) {
> > +		release_sock(sk);
> >  		return -EADDRNOTAVAIL;
> > +	}
> 
> so far i know it is kernel style one line one command
> 
> dev = rose_dev_get(&addr->srose_addr);
> if (dev == NULL)

The construct is acceptable because it was already there and also it's
not considered multiple statements for puposes of code formatting unlike

	if (!foo->bar)
		return ETOOFROB;

> maybe you want to send the code to kernel-janitors@vger.kernel.org
> to get more feedback ?

One this that is grave problem for this patch howeer (see
Documentation/SubmittingPatches) is the missing Signed-off-by: line.
Richard, wanna resubmit or is it ok for me to add your Signed-off-by?

Thanks,

  Ralf