From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56465)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Z4SNJ-0003ZX-8v
	for qemu-devel@nongnu.org; Mon, 15 Jun 2015 07:16:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Z4SNI-0006mn-52
	for qemu-devel@nongnu.org; Mon, 15 Jun 2015 07:16:21 -0400
Received: from hall.aurel32.net ([2001:bc8:30d7:101::1]:46350)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Z4SNI-0006mC-02
	for qemu-devel@nongnu.org; Mon, 15 Jun 2015 07:16:20 -0400
Date: Mon, 15 Jun 2015 13:16:17 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20150615111617.GC931@aurel32.net>
References: <1434117743-53520-1-git-send-email-yongbok.kim@imgtec.com>
	<1434117743-53520-2-git-send-email-yongbok.kim@imgtec.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1434117743-53520-2-git-send-email-yongbok.kim@imgtec.com>
Subject: Re: [Qemu-devel] [PATCH 01/13] target-mips: fix {D,
	W}RGPR in microMIPS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yongbok Kim <yongbok.kim@imgtec.com>
Cc: leon.alrae@imgtec.com, qemu-devel@nongnu.org

On 2015-06-12 15:02, Yongbok Kim wrote:
> rt, rs were swapped
> 
> Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>
> ---
>  target-mips/translate.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index f6ae0d3..d4a530d 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -12749,12 +12749,12 @@ static void gen_pool32axf (CPUMIPSState *env, DisasContext *ctx, int rt, int rs)
>          case RDPGPR:
>              check_cp0_enabled(ctx);
>              check_insn(ctx, ISA_MIPS32R2);
> -            gen_load_srsgpr(rt, rs);
> +            gen_load_srsgpr(rs, rt);
>              break;
>          case WRPGPR:
>              check_cp0_enabled(ctx);
>              check_insn(ctx, ISA_MIPS32R2);
> -            gen_store_srsgpr(rt, rs);
> +            gen_store_srsgpr(rs, rt);
>              break;
>          default:
>              goto pool32axf_invalid;

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

Note however that your subject should be {RD,WR}PGPR to correctly match
both instructions.


-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net