Re: [PATCH 1/2] ASoC: soc-compress: add a config item for soc-compress

[Vinod Koul <vinod.koul@intel.com>]

On Fri, Jun 12, 2015 at 01:33:25PM +0000, Jie, Yang wrote:
> > -----Original Message-----
> > From: Mark Brown [mailto:broonie@kernel.org]
> > Sent: Friday, June 12, 2015 9:00 PM
> > To: Jie, Yang
> > Cc: tiwai@suse.de; alsa-devel@alsa-project.org; Girdwood, Liam R;
> > vinod.koul@linux.intel.com; ramesh.babu@linux.intel.com; Zhang, Vivian
> > Subject: Re: [PATCH 1/2] ASoC: soc-compress: add a config item for soc-
> > compress
Okay didnt realise that its posted to alsa :( I need to remove all ref to
@linux id as am not using that anymore

> > 
> > On Fri, Jun 12, 2015 at 12:31:25PM +0000, Jie, Yang wrote:
> > 
> > > > here to make the drivers that do use compressed support select this
> > > > symbol
> > 
> > > As mentioned in commit message, we need add 'select
> > SND_SOC_COMPRESS'
> > > to driver  Kconfig(e.g. sound/soc/intel/Kconfig) when it is needed.
> > >
> > > > and since there's no config text there's no way for users to enable
> > > > this on a per system basis so this breaks all existing compressed audio
> > support.
> > >
> > > Do you mean I should add this message to 'Help' for this config item?
> > > Per my understanding, no existing driver really uses this compressed
> > > audio support currently, is that true?
> > 
> > Some of the existing Intel machine drivers have references to compressed
> > audio, it certainly looks like they're trying to use it.  Are you saying that this is
> > not actually the case?
>  
> Let me double confirm if the atom drivers are using it. Seems mfld platform is
> using that.
Yes and we will get runtime errors on all mfld-atom based drivers so please
add that on all atom machines

Since the dummy symbols are present so we wont get build errors. If a driver is
using the compressed API maybe we should not add dummy so that we catch ones
which are not including this config option, so for that point I would say
removal of dummay handlers looks best to me.

-- 
~Vinod