From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/10] arm64: Use BRK instruction for generic BUG traps
Date: Tue, 16 Jun 2015 15:51:05 +0100 [thread overview]
Message-ID: <20150616145105.GG30522@arm.com> (raw)
In-Reply-To: <1434036566-9848-1-git-send-email-Dave.Martin@arm.com>
Hi Dave,
On Thu, Jun 11, 2015 at 04:29:14PM +0100, Dave P Martin wrote:
> Currently, the minimal default BUG() implementation from asm-generic is
> used for arm64.
>
> This series uses the BRK software breakpoint instruction to generate a
> trap instead, similarly to most other arches, with the generic BUG code
> generating the dmesg boilerplate. This eliminates a fair amount of
> inlined code at BUG() and WARN() sites.
I think patches 3 and 8 are a bit OTT and don't really bring us much.
However, for the rest of the series (modulo my minor comments):
Reviewed-by: Will Deacon <will.deacon@arm.com>
Cheers,
Will
next prev parent reply other threads:[~2015-06-16 14:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 15:29 [PATCH 00/10] arm64: Use BRK instruction for generic BUG traps Dave Martin
2015-06-11 15:29 ` [PATCH 01/10] arm64/debug: Eliminate magic number for size of BRK instruction Dave Martin
2015-06-11 15:29 ` [PATCH 02/10] arm64/debug: Mask off all reserved bits from generated ESR values Dave Martin
2015-06-11 15:29 ` [PATCH 03/10] arm64: esr.h type fixes and cleanup Dave Martin
2015-06-11 15:29 ` [PATCH 04/10] arm64/debug: Eliminate magic number from ESR template definition Dave Martin
2015-06-11 15:29 ` [PATCH 05/10] arm64/debug: More consistent naming for the BRK ESR template macro Dave Martin
2015-06-11 15:29 ` [PATCH 06/10] arm64/debug: Move BRK ESR template macro into <asm/esr.h> Dave Martin
2015-06-11 15:29 ` [PATCH 07/10] arm64/debug: Simplify BRK insn opcode declarations Dave Martin
2015-06-11 15:29 ` [PATCH 08/10] arm64/debug: Move BRK types to a separate header Dave Martin
2015-06-11 15:29 ` [PATCH 09/10] arm64/BUG: Use BRK instruction for generic BUG traps Dave Martin
2015-06-16 14:48 ` Will Deacon
2015-06-17 11:35 ` Dave Martin
2015-06-17 16:42 ` Will Deacon
2015-06-11 15:29 ` [PATCH 10/10] arm64/BUG: Show explicit backtrace for WARNs Dave Martin
2015-06-16 14:49 ` Will Deacon
2015-06-17 11:13 ` Dave Martin
2015-06-16 14:51 ` Will Deacon [this message]
2015-06-16 16:51 ` [PATCH 00/10] arm64: Use BRK instruction for generic BUG traps Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150616145105.GG30522@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.