diff for duplicates of <20150616153808.GG10374@kernel.org> diff --git a/a/1.txt b/N1/1.txt index 292af7e..8db536d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -88,7 +88,7 @@ Can't you cache this somewhere? I.e. something like if (evsel->attr.type != PERF_TRACEPOINT) goto out; - if (unlikely(kvmppc_exit = -1)) { + if (unlikely(kvmppc_exit == -1)) { if (strcmp(KVMPPC_EXIT, evsel->name))) goto out; @@ -99,7 +99,7 @@ Can't you cache this somewhere? I.e. something like > + trap = raw_field_value(evsel->tp_format, "trap", data->raw_data); > + -> + if (trap = HV_DECREMENTER) +> + if (trap == HV_DECREMENTER) > + tp_ip = raw_field_value(evsel->tp_format, "pc", > + data->raw_data); @@ -216,7 +216,7 @@ other tools will have to do this patching too? I.e. here, where we should try to avoid looking at anything in 'al'. > -> if (thread = NULL) +> if (thread == NULL) > return -1; > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index 1e90c85..aa4dd49 100644 @@ -248,7 +248,7 @@ I.e. here, where we should try to avoid looking at anything in 'al'. > --- a/tools/perf/util/evsel.h > +++ b/tools/perf/util/evsel.h > @@ -355,4 +355,8 @@ for ((_evsel) = list_entry((_leader)->node.next, struct perf_evsel, node); \ -> (_evsel) && (_evsel)->leader = (_leader); \ +> (_evsel) && (_evsel)->leader == (_leader); \ > (_evsel) = list_entry((_evsel)->node.next, struct perf_evsel, node)) > > +u64 arch__get_ip(struct perf_evsel *evsel, struct perf_sample *data); diff --git a/a/content_digest b/N1/content_digest index 617a0b1..334f0c4 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01434423053-2173-1-git-send-email-hemant@linux.vnet.ibm.com\0" "From\0Arnaldo Carvalho de Melo <acme@kernel.org>\0" "Subject\0Re: [RFC PATCH] perf/kvm: Guest Symbol Resolution for powerpc\0" - "Date\0Tue, 16 Jun 2015 15:38:08 +0000\0" + "Date\0Tue, 16 Jun 2015 12:38:08 -0300\0" "To\0Hemant Kumar <hemant@linux.vnet.ibm.com>\0" "Cc\0linuxppc-dev@lists.ozlabs.org" linux-kernel@vger.kernel.org @@ -107,7 +107,7 @@ "\tif (evsel->attr.type != PERF_TRACEPOINT)\n" "\t\tgoto out;\n" "\n" - "\tif (unlikely(kvmppc_exit = -1)) {\n" + "\tif (unlikely(kvmppc_exit == -1)) {\n" "\t\tif (strcmp(KVMPPC_EXIT, evsel->name)))\n" "\t\t\tgoto out;\n" "\n" @@ -118,7 +118,7 @@ "\n" "> +\ttrap = raw_field_value(evsel->tp_format, \"trap\", data->raw_data);\n" "> +\n" - "> +\tif (trap = HV_DECREMENTER)\n" + "> +\tif (trap == HV_DECREMENTER)\n" "> +\t\ttp_ip = raw_field_value(evsel->tp_format, \"pc\",\n" "> +\t\t\t\t\tdata->raw_data);\n" "\n" @@ -235,7 +235,7 @@ "I.e. here, where we should try to avoid looking at anything in 'al'.\n" "\n" "> \n" - "> \tif (thread = NULL)\n" + "> \tif (thread == NULL)\n" "> \t\treturn -1;\n" "> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c\n" "> index 1e90c85..aa4dd49 100644\n" @@ -267,7 +267,7 @@ "> --- a/tools/perf/util/evsel.h\n" "> +++ b/tools/perf/util/evsel.h\n" "> @@ -355,4 +355,8 @@ for ((_evsel) = list_entry((_leader)->node.next, struct perf_evsel, node); \t\\\n" - "> (_evsel) && (_evsel)->leader = (_leader);\t\t\t\t\t\\\n" + "> (_evsel) && (_evsel)->leader == (_leader);\t\t\t\t\t\\\n" "> (_evsel) = list_entry((_evsel)->node.next, struct perf_evsel, node))\n" "> \n" "> +u64 arch__get_ip(struct perf_evsel *evsel, struct perf_sample *data);\n" @@ -304,4 +304,4 @@ "> -- \n" > 1.9.3 -f128ec77f7194c4c6253a8bc44122eb361dc0e5dc2e4b2d59f42dc3c13f7766f +5613939af6529d590404e0b2c30f153a7216e2b7110ede4ccb4e1deb1e4fb045
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.