Re: [PATCH V5 2/4] KVM: x86/vPMU: Create vPMU interface for VMX and SVM

[Joerg Roedel <joro@8bytes.org>]

On Fri, Jun 12, 2015 at 01:34:54AM -0400, Wei Huang wrote:
> This patch splits existing vPMU code into a common vPMU interface (pmc.c)
> and Intel specific vPMU code (pmu_intel.c) using the following steps:
> 
> - Part of arechitectural vPMU code is extracted and moved to pmu_intel.c
>   file. They are hooked up with the newly-defined intel_pmu_ops, which will
>   be called from pmu interface;
> - Create a dummy pmu_amd.c file for AMD SVM with empty functions;
> 
> All architectural vPMU functions are now called via PMU function dispatcher.
> This function dispatcher is defined in kvm_x86_ops->pmu_ops, which is
> initialized by sub-arch. Also note that Intel and AMD modules are now
> generated by combinig their corresponding arch files (vmx.c/svm.c) and pmu
> files (pmu_intel.c/pmu_amd.c).
> 
> Tested-by: Radim Krčmář <rkrcmar@redhat.com>
> Signed-off-by: Wei Huang <wei@redhat.com>

Reviewed-by: Joerg Roedel <jroedel@suse.de>