From: Wei Liu <wei.liu2@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 2/2] libxc: fix xc_dom_load_elf_symtab
Date: Wed, 17 Jun 2015 10:56:24 +0100 [thread overview]
Message-ID: <20150617095624.GF1813@zion.uk.xensource.com> (raw)
In-Reply-To: <1434038720-39031-3-git-send-email-roger.pau@citrix.com>
On Thu, Jun 11, 2015 at 06:05:20PM +0200, Roger Pau Monne wrote:
> xc_dom_load_elf_symtab was incorrectly trying to perform the same
> calculations already done in elf_parse_bsdsyms when load == 0 is used.
> Instead of trying to repeat the calculations, just trust what
> elf_parse_bsdsyms has already accounted for.
>
> This also simplifies the code by allowing the non-load case to return
> earlier.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
next prev parent reply other threads:[~2015-06-17 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 16:05 [PATCH 0/2] Fix BSD symtab/strtab loading Roger Pau Monne
2015-06-11 16:05 ` [PATCH 1/2] libelf: fix elf_parse_bsdsyms call Roger Pau Monne
2015-06-11 16:05 ` [PATCH 2/2] libxc: fix xc_dom_load_elf_symtab Roger Pau Monne
2015-06-17 9:56 ` Wei Liu [this message]
2015-06-17 11:14 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617095624.GF1813@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.