From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Christian Ruppert
<christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org>,
jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: designware: Make sure the device is suspended before disabling runtime PM
Date: Wed, 17 Jun 2015 12:16:45 +0200 [thread overview]
Message-ID: <20150617101645.GA1517@katana> (raw)
In-Reply-To: <1434532118-119906-1-git-send-email-mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
On Wed, Jun 17, 2015 at 12:08:38PM +0300, Mika Westerberg wrote:
> The driver calls pm_runtime_put() right before pm_runtime_disable() in its
> ->remove() hook to make sure clock is gated etc. However, it turns out that
> pm_runtime_put() only calls ->idle() hook without actually suspending
> anything. The following pm_runtime_disable() will prevent the driver from
> suspending thus leaving it "active".
>
> It is better to suspend the device synchronously to make sure it is
> actually suspended before disabling runtime PM from it.
>
> While there, undo call to pm_runtime_use_autosuspend().
>
> Signed-off-by: Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
For current? For next? stable?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-06-17 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 9:08 [PATCH] i2c: designware: Make sure the device is suspended before disabling runtime PM Mika Westerberg
[not found] ` <1434532118-119906-1-git-send-email-mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-06-17 10:16 ` Wolfram Sang [this message]
2015-06-17 10:24 ` Mika Westerberg
2015-06-21 19:31 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617101645.GA1517@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=christian.ruppert-Yycd8EPnGM5BDgjK7y7TUQ@public.gmane.org \
--cc=jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.