From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5GN7-0007T7-Cg for qemu-devel@nongnu.org; Wed, 17 Jun 2015 12:39:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5GN1-00085G-KS for qemu-devel@nongnu.org; Wed, 17 Jun 2015 12:39:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40432) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5GN1-00084z-Ct for qemu-devel@nongnu.org; Wed, 17 Jun 2015 12:39:23 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id C50D233B375 for ; Wed, 17 Jun 2015 16:39:22 +0000 (UTC) Date: Wed, 17 Jun 2015 18:39:19 +0200 From: "Michael S. Tsirkin" Message-ID: <20150617183752-mutt-send-email-mst@redhat.com> References: <20150617094829-mutt-send-email-mst@redhat.com> <55812BC4.3000600@redhat.com> <20150617121148-mutt-send-email-mst@redhat.com> <55815B06.5030508@redhat.com> <20150617114053.GG2122@work-vm> <55815D8C.3080904@redhat.com> <20150617120746.GH2122@work-vm> <5581661A.1060101@redhat.com> <20150617163731-mutt-send-email-mst@redhat.com> <87381q47kg.fsf@neno.neno> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87381q47kg.fsf@neno.neno> Subject: Re: [Qemu-devel] [PATCH] Migration compatibility for serial List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: amit.shah@redhat.com, Paolo Bonzini , "Dr. David Alan Gilbert" , qemu-devel@nongnu.org On Wed, Jun 17, 2015 at 06:34:55PM +0200, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Wed, Jun 17, 2015 at 02:20:42PM +0200, Paolo Bonzini wrote: > >> > >> > >> On 17/06/2015 14:07, Dr. David Alan Gilbert wrote: > >> > Of course for us on RHEL our minor releases don't correspond to > >> > QEMU minor releases, so we already support migrating from our > >> > downstream 7.1 (QEMU 2.1) derivative to our 7.0 (1.5.3) version. > >> > And the reason for this patch series is to support something >2.2 > >> > migrating back to that 2.1 (or maybe even to that 1.5.3). > >> > > >> > I don't believe we're alone in wanting to be able to do that type > >> > of thing; > >> > >> Others may prefer to have migration only work when it is absolutely sure > >> that it works. It is much easier to add hacks on top of what upstream > >> QEMU does (e.g. using the static checker), than to remove the hacks. > >> > >> If we really didn't care about others' support for bidirectional > >> migration, we would have kept the static checker internal to Red Hat. > >> Or we wouldn't have bothered to refine the .needed functions, and so on. > >> > >> Paolo > > > > What we need to decide is how major is the breakage. > > If it's minor - like some lost characters - then it's not > > worth breaking migration for most users. > > And I think this should be a property so people can > > force strict mode if they really want to. > > > > If it's a major breakage, it's harder to decide: > > some people might be able to retry migration later. > > Maybe a flag to enable this mode would make sense? > > Also, maybe it would be better to fail migration on source > > rather than send something destination can't handle? > > Source don't know if destination understand it or not. That is the > whole point of being optional. Source sends it if it is needed. > Destination can handle it (or not). > > there are (at least) two qemu pc-2.2: > qemu-2.2 -M pc-2.2 > qemu-2.3 -M pc-2.2 > > Same machine type. Second is able to receive it. First one is not. > Source don't know what is on the other side. If user is going to put a: > > --dont_send_serial_because_I_don't_care > > Then it can as well just disable the serial device and live with it. > > Later, Juan. Just losing worst-case a couple of characters is not the same as losing serial functionality. We could have a flag to tell us what's on the other side, but that would need even more testing. So let's keep it simple. > > > > > But let's see what the symptoms are before we argue > > about this option. > > > >> > so you can either worry about not burdening upstream > >> > with compatibility patches like this, or think it's not fair > >> > to leave them out if others upstream might want them. How many > >> > others? Well I'd say it's got to be more than some of the other > >> > obscure features in QEMU!