All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Josef Bacik <jbacik@fb.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH V2] generic: add fiemap test that does prealloc
Date: Thu, 18 Jun 2015 07:32:00 +1000	[thread overview]
Message-ID: <20150617213159.GG10224@dastard> (raw)
In-Reply-To: <1434573149-4471-1-git-send-email-jbacik@fb.com>

On Wed, Jun 17, 2015 at 01:32:29PM -0700, Josef Bacik wrote:
> I noticed that btrfs wasn't setting unwritten on prealloc test, and then
> subsequently noticed that we weren't testing fiemap on prealloc extents with the
> fiemap-tester.  This patch adds another test that does the same as generic/225
> only with prealloc enabled.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@fb.com>
....
> +_require_xfs_io_command "fiemap"
> +_require_xfs_io_command "falloc"
> +
> +_scratch_mkfs > /dev/null 2>&1
> +_scratch_mount > /dev/null 2>&1
> +
> +rm -f $seqres.full
> +fiemapfile=$SCRATCH_MNT/$seq.fiemap
> +
> +[ -x $here/src/fiemap-tester ] || _notrun "fiemap-tester not built"
> +
> +seed=`date +%s`
> +
> +echo "using seed $seed" >> $seqres.full
> +
> +echo "fiemap run with sync"
> +$here/src/fiemap-tester -q -S -s $seed -r 200 $fiemapfile 2>&1 | \
> +	tee -a $seqres.full
> +
> +if [ $? -ne 0 ]; then
> +	if grep -q "Operation not supported" $seqres.full; then
> +	      _notrun "FIEMAP not supported by this filesystem type: $FSTYP"
> +	fi
> +	status=$?
> +	exit
> +fi

No need for the FIEMAP not supported check - that is done by the
'+_require_xfs_io_command "fiemap"' line above and so any failure
of fiemap-tester is something that should fail the test.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2015-06-17 21:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17 20:32 [PATCH V2] generic: add fiemap test that does prealloc Josef Bacik
2015-06-17 21:32 ` Dave Chinner [this message]
2015-06-17 21:33   ` Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150617213159.GG10224@dastard \
    --to=david@fromorbit.com \
    --cc=fstests@vger.kernel.org \
    --cc=jbacik@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.