Re: [Qemu-devel] [PATCH v4 0/5] Some fixes related to scsi-generic

[Dimitris Aragiorgis <dimara@arrikto.com>]

[-- Attachment #1: Type: text/plain, Size: 2171 bytes --]

Hi,

did you have the time to take a look at this? Is there anything
pending from my side?

Thanks,
dimara

* Dimitris Aragiorgis <dimara@arrikto.com> [2015-05-29 08:15:34 +0300]:

> Hi,
> 
> * Dimitris Aragiorgis <dimara@arrikto.com> [2015-05-20 12:57:34 +0300]:
> 
> > Hi all,
> > 
> > These four patches make slight changes to the way QEMU handles SCSI
> > generic devices to fix a number of small problems.
> > 
> > I am sending them against the master branch, since I don't know if they
> > can be considered bugfixes.
> > 
> > Thanks,
> > dimara
> > 
> > v4 (rebased to current master):
> > * Avoid errno clobbering with DPRINTF + strerror() (Eric's comment)
> > * Use {} in #define macro even if it is not necessary (single commands)
> > 
> 
> Any news on this?
> 
> Thanks,
> dimara
> 
> 
> > v3 (rebased to current master):
> > * Avoid bit-rot in DPRINTF (adopt Eric's suggestion)
> > * Address Kevin's comments (DEBUF_FLOPPY, line > 80 chars, SG device)
> > * Mention Kevin's comment wrt disk flush in the corresponding commit
> > 
> > v2:
> > * remove duplicate check for sg inside iscsi_co_flush()
> > * remove DEBUG_BLOCK_PRINT in block/raw-posix.c
> > * use DPRINTF for debugging in block/raw-posix.c
> > 
> > PS: Paolo suggested to use a tracepoint inside hdev_is_sg() but I chose DPRINTF
> > instead. It would make sense to add a tracepoint for bdrv_is_sg() (just like
> > most bdrv_* commands) but this is too much for now since it just returns the
> > bs->sg flag (and is not an actual driver function). If you insist I'll change
> > it in v3.
> > 
> > Dimitris Aragiorgis (5):
> >   block: Use bdrv_is_sg() everywhere
> >   Fix migration in case of scsi-generic
> >   raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT
> >   raw-posix: Use DPRINTF for DEBUG_FLOPPY
> >   raw-posix: Introduce hdev_is_sg()
> > 
> >  block.c           |    6 ++--
> >  block/io.c        |    3 +-
> >  block/iscsi.c     |    4 ---
> >  block/raw-posix.c |   91 +++++++++++++++++++++++++++++++----------------------
> >  4 files changed, 58 insertions(+), 46 deletions(-)
> > 
> > -- 
> > 1.7.10.4
> > 



[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]