From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] x_table: align per cpu xt_counter
Date: Thu, 18 Jun 2015 21:04:34 +0200 [thread overview]
Message-ID: <20150618190434.GA3454@salvia> (raw)
In-Reply-To: <20150617170815.GF31987@breakpoint.cc>
On Wed, Jun 17, 2015 at 07:08:15PM +0200, Florian Westphal wrote:
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > From: Eric Dumazet <edumazet@google.com>
> >
> > Let's force a 16 bytes alignment on xt_counter percpu allocations,
> > so that bytes and packets sit in same cache line.
> >
> > xt_counter being exported to user space, we cannot add __align(16) on
> > the structure itself.
>
> Sorry, I was away. Looks great.
>
> Acked-by: Florian Westphal <fw@strlen.de>
Applied, thanks Eric and Florian !
next prev parent reply other threads:[~2015-06-18 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 1:10 [PATCH net-next] x_table: align per cpu xt_counter Eric Dumazet
2015-06-17 17:08 ` Florian Westphal
2015-06-18 19:04 ` Pablo Neira Ayuso [this message]
2015-06-18 10:43 ` David Miller
2015-06-18 10:50 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150618190434.GA3454@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.