Re: [PATCH v3 1/7] clk: introduce clk_div_mask() helper

[Stephen Boyd <sboyd@codeaurora.org>]

On 03/31, Andy Shevchenko wrote:
> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> index 5591ea7..20b0b67 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -353,6 +353,11 @@ struct clk_divider {
>  	spinlock_t	*lock;
>  };
>  
> +static inline unsigned long clk_div_mask(u8 width)
> +{
> +	return (1 << width) - 1;
> +}
> +

Why not just change drivers to use GENMASK? It's a proven and
tested way to generate a bitmask.

So I'd rather see drivers converted to use that macro directly
especially because the mask may need to start at some bit that
isn't 0.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project