From: Andi Kleen <andi@firstfloor.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Mike Snitzer <snitzer@redhat.com>,
Andi Kleen <andi@firstfloor.org>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [dm-devel] WARNING: at fs/block_dev.c:5 when removing LV on removed device
Date: Thu, 18 Jun 2015 21:53:31 +0200 [thread overview]
Message-ID: <20150618195331.GD19417@two.firstfloor.org> (raw)
In-Reply-To: <20150618190815.GA6390@redhat.com>
> In that case if I do umount after device has gone away, I can see above
> WARN(). And it does seem to be coming from.
>
> WARN_ON_ONCE(write_inode_now(inode, true))
>
> If we failed to write back inode, then warning about it sounds right?
WARN() is for detecting kernel internal consistency problems, like
potential bugs. It's not for handling IO errors or really
everything that can happen on a non buggy kernel.
> What's wrong with that? Should it be just a kernel log of level KERN_WARN
> instead?
Yes. Something like that.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2015-06-18 19:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 16:57 WARNING: at fs/block_dev.c:5 when removing LV on removed device Andi Kleen
2015-06-18 18:04 ` Mike Snitzer
2015-06-18 18:08 ` Andi Kleen
2015-06-18 18:16 ` Mike Snitzer
2015-06-18 19:08 ` [dm-devel] " Vivek Goyal
2015-06-18 19:28 ` Mike Snitzer
2015-06-19 6:47 ` Christoph Hellwig
2015-06-22 17:46 ` Vivek Goyal
2015-06-22 17:46 ` Vivek Goyal
2015-06-22 17:52 ` Tejun Heo
2015-06-22 17:52 ` Tejun Heo
2015-06-22 17:55 ` Vivek Goyal
2015-06-22 17:55 ` Vivek Goyal
2015-06-23 10:08 ` Christoph Hellwig
2015-06-18 19:53 ` Andi Kleen [this message]
2015-06-18 21:01 ` [dm-devel] " Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150618195331.GD19417@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.