From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756230AbbFRUSo (ORCPT ); Thu, 18 Jun 2015 16:18:44 -0400 Received: from mail.kernel.org ([198.145.29.136]:34093 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753769AbbFRUSg (ORCPT ); Thu, 18 Jun 2015 16:18:36 -0400 Date: Thu, 18 Jun 2015 17:18:29 -0300 From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Adrian Hunter , Borislav Petkov , David Ahern , Don Zickus , Frederic Weisbecker , He Kuang , Jiri Olsa , Li Zhang , Masami Hiramatsu , Namhyung Kim , Naohiro Aota , Peter Zijlstra , pi3orama@163.com, Stephane Eranian , Sukadev Bhattiprolu , Wang Nan , Zefan Li Subject: [RFC] hotkey for disabling/enabling events in 'perf top' TUI was Re: [GIT PULL 0/8] perf/core improvements and fixes Message-ID: <20150618201829.GF3079@kernel.org> References: <1434576155-30038-1-git-send-email-acme@kernel.org> <20150618074010.GA3194@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150618074010.GA3194@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Jun 18, 2015 at 09:40:10AM +0200, Ingo Molnar escreveu: > * Arnaldo Carvalho de Melo wrote: > > User visible: > > - Allow disabling/enabling events dynamicly in 'perf top': > > a 'perf top' session can instantly become a 'perf report' > > one, i.e. going from dynamic analysis to a static one, > > returning to a dynamic one is possible, to toogle the > > modes, just press CTRL+z. (Arnaldo Carvalho de Melo) > Nice!! :-) > Btw., it would be nice if the status line carried information about whether > collection is 'frozen' or running, at a glance. A hint might also suggest how to > unfreeze the session - in case someone pressed Ctrl-Z to suspend the perf top > session ... Right, and I think we better find other hotkey and make Ctrl+Z work like with other tools, i.e. suspend: [acme@zoo linux]$ mutt [1]+ Stopped mutt [acme@zoo linux]$ vim [2]+ Stopped vim [acme@zoo linux]$ The perf TUI should work like that as well... Ideas? We already have: h/?/F1 Show this window UP/DOWN/PGUP PGDN/SPACE Navigate q/ESC/CTRL+C Exit browser For multiple event sessions: TAB/UNTAB Switch events For symbolic views (--sort has sym): -> Zoom into DSO/Threads & Annotate current symbol <- Zoom out a Annotate current symbol C Collapse all callchains d Zoom into current DSO D Show some developer debug info E Expand all callchains F Toggle percentage of filtered entries H Display column headers i Show header information P Print histograms to perf.hist.N r Run available scripts s Switch to another data file in PWD t Zoom into current Thread V Verbose (DSO names in callchains, etc) z Toggle zeroing of samples / Filter symbol by name > Also, there's now a GUI inconsistency with perf report: which will now exit on > Ctrl-Z. It should probably print a warning in the status line instead, that > freezing/unfreezing only works in 'perf top'. I'll fix that. - Arnaldo