From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 5/5] dmaengine: mv_xor: de-duplicate mv_chan_set_mode*()
Date: Fri, 19 Jun 2015 12:12:40 +0200 [thread overview]
Message-ID: <20150619101240.GA11732@lukather> (raw)
In-Reply-To: <1434557086-9520-6-git-send-email-thomas.petazzoni@free-electrons.com>
On Wed, Jun 17, 2015 at 06:04:46PM +0200, Thomas Petazzoni wrote:
> When commit 6f166312c6ea2 ("dmaengine: mv_xor: add support for a38x
> command in descriptor mode") added support for the descriptor mode
> available in Marvell Armada 38x and later SoCs, it added a new
> function mv_chan_set_mode_to_desc() which allows to configure a XOR
> channel to get the specific operation to be done from each individual
> DMA descriptor.
>
> However, this function was mainly a duplicate of the existing
> mv_chan_set_mode(), with just the operation being different.
>
> This commit re-organizes the code into a single mv_chan_set_mode()
> function, which takes the operation mode as argument, and the
> mv_xor_channel_add() function decides whether to use
> XOR_OPERATION_MODE_IN_DESC or XOR_OPERATION_MODE_XOR.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150619/f21a6895/attachment.sig>
prev parent reply other threads:[~2015-06-19 10:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 16:04 [PATCHv2 0/5] dmaengine: mv_xor fixes and improvements Thomas Petazzoni
2015-06-17 16:04 ` [PATCHv2 1/5] dmaengine: mv_xor: fix big endian operation in register mode Thomas Petazzoni
2015-06-17 16:04 ` [PATCHv2 2/5] dmaengine: mv_xor: add suspend/resume support Thomas Petazzoni
2015-06-17 16:04 ` [PATCHv2 3/5] dmaengine: mv_xor: remove support for dmacap, * DT properties Thomas Petazzoni
2015-06-19 10:06 ` [PATCHv2 3/5] dmaengine: mv_xor: remove support for dmacap,* " Maxime Ripard
2015-06-17 16:04 ` [PATCHv2 4/5] dmaengine: mv_xor: remove mv_xor_chan->current_type field Thomas Petazzoni
2015-06-19 10:06 ` Maxime Ripard
2015-06-17 16:04 ` [PATCHv2 5/5] dmaengine: mv_xor: de-duplicate mv_chan_set_mode*() Thomas Petazzoni
2015-06-19 10:12 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150619101240.GA11732@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.