All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Yang Z Zhang <yang.z.zhang@intel.com>,
	"Liuqiming (John)" <john.liuqiming@huawei.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"peter.huangpeng@huawei.com" <peter.huangpeng@huawei.com>
Subject: Re: performace issue when turn on apicv
Date: Fri, 19 Jun 2015 10:23:00 -0400	[thread overview]
Message-ID: <20150619142300.GK21541@l.oracle.com> (raw)
In-Reply-To: <5582AD090200007800086884@mail.emea.novell.com>

On Thu, Jun 18, 2015 at 10:35:37AM +0100, Jan Beulich wrote:
> >>> On 18.06.15 at 11:18, <yang.z.zhang@intel.com> wrote:
> > Jan Beulich wrote on 2015-06-18:
> >>>>> On 18.06.15 at 10:53, <yang.z.zhang@intel.com> wrote:
> >>> Jan Beulich wrote on 2015-06-18:
> >>>>>>> On 18.06.15 at 10:20, <JBeulich@suse.com> wrote:
> >>>>> Apart from that I notice that the EXIT_REASON_EOI_INDUCED handling
> >>>>> also adds about the same number of ticks...
> >>>> 
> >>>> Are there any other devices in the guest causing meaningful amounts
> >>>> of interrupts (I suppose the SSD itself is using just one)? I ask
> >>>> since I wonder whether e.g. there may be lock contention in
> >> vioapic_update_EOI().
> >>> 
> >>> The EXIT_REASON_EOI_INDUCED is for local apic time.
> >> 
> >> ??? (I.e. I don't see the connection between the context and your reply.
> >> Perhaps I'm missing something obvious...)
> > 
> > I mean the lots of EXIT_REASON_EOI_INDUCEDis for local apic time which is 
> > edge-trigger. So it will not call vioapic_update_EOI.
> 
> Okay, this then suggests the problem being hvm_dpci_msi_eoi(),
> albeit looking at it I can't immediately see why it would take long.

We do take two spin-locks (d->event_lock) and (desc->lock) and also
can IPI set_eoi_ready across different CPUs.

Perhaps it might be worth adding some TRACE with the time taken
to get the locks and also doing the IPIs?

> 
> Jan
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

  reply	other threads:[~2015-06-19 14:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11  7:23 performace issue when turn on apicv Liuqiming (John)
2015-06-11  7:35 ` Zhang, Yang Z
2015-06-11  8:09   ` Liuqiming (John)
2015-06-11  8:34     ` Zhang, Yang Z
2015-06-18  8:02       ` Liuqiming (John)
2015-06-18  8:20         ` Jan Beulich
2015-06-18  8:52           ` Jan Beulich
2015-06-18  8:53             ` Zhang, Yang Z
2015-06-18  9:15               ` Jan Beulich
2015-06-18  9:18                 ` Zhang, Yang Z
2015-06-18  9:35                   ` Jan Beulich
2015-06-19 14:23                     ` Konrad Rzeszutek Wilk [this message]
2015-06-18  9:31           ` Zhang, Yang Z
     [not found] <mailman.2928.1434616580.28840.xen-devel@lists.xen.org>
2015-06-18 14:55 ` Jiangyifei
2015-06-19 10:42   ` Jan Beulich
2015-06-22  2:48     ` Jiangyifei
2015-06-22  9:56       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150619142300.GK21541@l.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=JBeulich@suse.com \
    --cc=john.liuqiming@huawei.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.