From mboxrd@z Thu Jan 1 00:00:00 1970 From: dmitry.torokhov@gmail.com (Dmitry Torokhov) Date: Fri, 19 Jun 2015 15:32:39 -0700 Subject: [PATCH v3 2/2] mfd: flexcom: add a driver for Atmel Flexible Serial Communication Unit In-Reply-To: <4b10b4bf7824134dfc91c5e4f25de3086163bba7.1434703451.git.cyrille.pitchen@atmel.com> References: <4b10b4bf7824134dfc91c5e4f25de3086163bba7.1434703451.git.cyrille.pitchen@atmel.com> Message-ID: <20150619223239.GA24540@dtor-ws> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Cyrille, On Fri, Jun 19, 2015 at 10:49:35AM +0200, Cyrille Pitchen wrote: > + > + clk_prepare_enable(clk); I believe you need to have error handling here, not because it will actually fail but to handle deferrals. > + version = readl(map + FX_VERSION); > + writel(mr, map + FX_MR); > + clk_disable_unprepare(clk); > + > + dev_info(&pdev->dev, "version: %#x, mode: %s\n", version, mode); > + > + return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); > +} Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v3 2/2] mfd: flexcom: add a driver for Atmel Flexible Serial Communication Unit Date: Fri, 19 Jun 2015 15:32:39 -0700 Message-ID: <20150619223239.GA24540@dtor-ws> References: <4b10b4bf7824134dfc91c5e4f25de3086163bba7.1434703451.git.cyrille.pitchen@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4b10b4bf7824134dfc91c5e4f25de3086163bba7.1434703451.git.cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Cyrille Pitchen Cc: nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org, boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Cyrille, On Fri, Jun 19, 2015 at 10:49:35AM +0200, Cyrille Pitchen wrote: > + > + clk_prepare_enable(clk); I believe you need to have error handling here, not because it will actually fail but to handle deferrals. > + version = readl(map + FX_VERSION); > + writel(mr, map + FX_MR); > + clk_disable_unprepare(clk); > + > + dev_info(&pdev->dev, "version: %#x, mode: %s\n", version, mode); > + > + return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); > +} Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756499AbbFSWdA (ORCPT ); Fri, 19 Jun 2015 18:33:00 -0400 Received: from mail-ie0-f170.google.com ([209.85.223.170]:36014 "EHLO mail-ie0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756365AbbFSWco (ORCPT ); Fri, 19 Jun 2015 18:32:44 -0400 Date: Fri, 19 Jun 2015 15:32:39 -0700 From: Dmitry Torokhov To: Cyrille Pitchen Cc: nicolas.ferre@atmel.com, boris.brezillon@free-electrons.com, alexandre.belloni@free-electrons.com, sameo@linux.intel.com, lee.jones@linaro.org, mark.rutland@arm.com, devicetree@vger.kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, robh+dt@kernel.org, galak@codeaurora.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 2/2] mfd: flexcom: add a driver for Atmel Flexible Serial Communication Unit Message-ID: <20150619223239.GA24540@dtor-ws> References: <4b10b4bf7824134dfc91c5e4f25de3086163bba7.1434703451.git.cyrille.pitchen@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4b10b4bf7824134dfc91c5e4f25de3086163bba7.1434703451.git.cyrille.pitchen@atmel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Cyrille, On Fri, Jun 19, 2015 at 10:49:35AM +0200, Cyrille Pitchen wrote: > + > + clk_prepare_enable(clk); I believe you need to have error handling here, not because it will actually fail but to handle deferrals. > + version = readl(map + FX_VERSION); > + writel(mr, map + FX_MR); > + clk_disable_unprepare(clk); > + > + dev_info(&pdev->dev, "version: %#x, mode: %s\n", version, mode); > + > + return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); > +} Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/